Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipestat status flags are not working correctly #463

Closed
nsheff opened this issue Feb 16, 2024 · 1 comment
Closed

pipestat status flags are not working correctly #463

nsheff opened this issue Feb 16, 2024 · 1 comment

Comments

@nsheff
Copy link
Contributor

nsheff commented Feb 16, 2024

If I run a job and it fails, it creates a "_failed.flag", correctly.

When I try to do looper run, it won't run these because they have failed flags -- as expected.

So, I try looper rerun, and what happens is broken. it says:

## [2 of 7] sample: demo1; pipeline: add_to_seqcol
Initialized looper config file: /home/nsheff/code/seqcolapi/analysis/demo/looper_pipestat_config.yaml
Initialize PipestatBackend
Initialize FileBackend
> Skipping sample because rerun requested, but no failed flag found. Status: waiting

That's strange, because there was just a failed flag there, from the previous run... so I double-check and, sure enough, it has changed the flag from failed to waiting!

This doesn't make any sense. It should not change the flag from failed to waiting, and then complain that "no failed flag" is found!

@nsheff nsheff added the bug label Feb 16, 2024
@nsheff nsheff added this to the v1.8.0 milestone Feb 16, 2024
donaldcampbelljr added a commit that referenced this issue Mar 13, 2024
@donaldcampbelljr
Copy link
Contributor

Ok, I found where the issue is; it is due to a fix for #169, specifically this commit: 6ccebc6

I've added a fix here: #480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants