-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make suggested changes to looper init
#514
Comments
added generic flag (--generic, -g), if user supplied, looper will give the default generic config file. |
the new looper init made me add 2 pipeline interfaces, and then it created a broken init, because the second one was blank... it created this broken config file for me:
(notice two hyphens)
some other thoughts:
|
I fixed the additional dash when writing the interfaces. I was accidentally wrapping a list within a list.
To run basic looper examples, you need a piface. This seemed reasonable to add the path to a generic one if the user does not provide any and then ask them if they'd like to initialize the file. Especially since this is targeted towards beginners/is a tutorial.
I can make a note that pressing enter simply continues?
I seem to remember having a difficult time getting tab completion to work last time I investigated adding it to looper. I believe we had agreed to bail on that for the time being. |
Oh I think I misunderstood your initial comment. It was not adding a blank interface. I had wrapped the list of interfaces into another list and this causes yaml.dump to add another hyphen to the first entry. To clarify: if you press enter to continue during the first piface entry, it will place a path to a generic piface there and then ask the user if they'd like to initialize it (if it does not already exist). |
The text was updated successfully, but these errors were encountered: