Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

divvy dev suggestions #527

Open
nsheff opened this issue Oct 9, 2024 · 0 comments
Open

divvy dev suggestions #527

nsheff opened this issue Oct 9, 2024 · 0 comments
Assignees
@donaldcampbelljr
Labels
enhancement

Comments

@nsheff
Copy link
Contributor

nsheff commented Oct 9, 2024

As I was fixing a divvy bug with template paths, I came up with these two suggestions to improve developer experience on divvy code

  • def templates_folder(self): - should be deprecated, since we actually specify the path within the divcfg; so this is never used!
  • def write(self, filename=None): -- should be renamed to write_config? It's confusing because this is not writing the script, which is done by write_script, even though there is a divvy write. In other words, divvy write calls write_script, not write, which is non-parallel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donaldcampbelljr donaldcampbelljr

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nsheff @donaldcampbelljr