Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev aaron #209

Merged
merged 17 commits into from
Jul 19, 2023
Merged

Dev aaron #209

merged 17 commits into from
Jul 19, 2023

Conversation

ayobi
Copy link
Member

@ayobi ayobi commented Jul 19, 2023

No description provided.

@nleroy917 nleroy917 self-requested a review July 19, 2023 19:41
Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - there might be areas we can optimize in the future, but for now this is good to solve #207

except Exception as e:
raise HTTPException(
status_code=400,
detail=f"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? no detail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note sure about this from @khoroshevskyi

toast.success('Successfully updated the project!');
},
onError: (error: AxiosError) => {
toast.error(`Failed to update project: ${error}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the near future, we can add proper error handling

@ayobi
Copy link
Member Author

ayobi commented Jul 19, 2023

True, I'll address that and others with #164

@ayobi ayobi merged commit a7b9f4d into dev Jul 19, 2023
1 check passed
@ayobi ayobi deleted the dev_aaron branch August 22, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants