-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev aaron #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - there might be areas we can optimize in the future, but for now this is good to solve #207
except Exception as e: | ||
raise HTTPException( | ||
status_code=400, | ||
detail=f"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? no detail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note sure about this from @khoroshevskyi
toast.success('Successfully updated the project!'); | ||
}, | ||
onError: (error: AxiosError) => { | ||
toast.error(`Failed to update project: ${error}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in the near future, we can add proper error handling
True, I'll address that and others with #164 |
No description provided.