Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize web interface fetching of PEP annotation data. New /annotation endpoint #235

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Optimize web interface fetching of PEP annotation data. New /annotation endpoint #235

merged 5 commits into from
Dec 5, 2023

Conversation

nleroy917
Copy link
Member

@nleroy917 nleroy917 commented Dec 4, 2023 •
edited by khoroshevskyi
Loading

Fixes #234

This does two things:

  1. Creates a new /project/{namespace}/{project}/annotation endpoint to get a PEPs metadata, and
  2. Switches the Project page on the web interface to use this instead of getting the full project info. The reason for this is that the annotation is much faster to fetch for projects with many samples and we don't need the samples

TODO:

  • Bump version
  • Update changelog

@nleroy917 nleroy917 mentioned this pull request Dec 4, 2023
Closed
khoroshevskyi
khoroshevskyi approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@khoroshevskyi khoroshevskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nleroy917 nleroy917 merged commit 111138c into master Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khoroshevskyi khoroshevskyi khoroshevskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create annotation endpoint
2 participants
@nleroy917 @khoroshevskyi