Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added views endpoints #259

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Added views endpoints #259

merged 6 commits into from
Jan 12, 2024

Conversation

khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Jan 10, 2024 •
edited
Loading

  • Brainstorm all endpoints...

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 10, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d99b99
Status: ✅  Deploy successful!
Preview URL: https://0132b672.pephub.pages.dev
Branch Preview URL: https://views-endpoints.pephub.pages.dev

View logs

nleroy917
nleroy917 requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that this makes sense. If there are two types of views: 1) project_view and 2) sample_view should it be /projects/{namespace}/{name}/views/ and then /projects/{namespace}/{name}/samples/views ?

@nleroy917 nleroy917 merged commit 07b8583 into dev Jan 12, 2024
2 checks passed
@khoroshevskyi khoroshevskyi deleted the views_endpoints branch January 19, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nleroy917 nleroy917 nleroy917 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khoroshevskyi @nleroy917