Browse page #387
Merged
Browse page #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nleroy917
approved these changes
Sep 11, 2024
| style={{ scrollSnapType: 'x mandatory' }} | ||
| > | ||
| {namespaces ? ( | ||
| Object.values(namespaces).map((item, index) => ( |
There was a problem hiding this comment.
Not a huge deal, but a pattern I like over this is:
{namespaces && (
<div> { ... } </div>
)}Instead of:
{namespaces ? (
<div> { ... } </div>
) : null
}Almost the same, but the first is a bit cleaner
|
|
||
| return ( | ||
| <div className="position-relative"> | ||
| {renderLongRow()} |
There was a problem hiding this comment.
Any reason to not just make this a component? I.e. const LongRow = () => { ... }
Comment on lines
6
to
7
| import 'bootstrap/dist/css/bootstrap.min.css' | ||
| import "bootstrap/dist/js/bootstrap.bundle.min.js" |
There was a problem hiding this comment.
Is this necessary? I'm pretty sure I have this on the main.tsx component...
|
|
||
| export const ProjectAccordion = (props: Props) => { | ||
| const { projects } = props; | ||
| const [openIndex, setOpenIndex] = useState(null); |
Comment on lines
20
to
30
| const formatDate = (dateString: string) => { | ||
| const date = new Date(dateString); | ||
| return date.toLocaleString('en-US', { | ||
| year: 'numeric', | ||
| month: 'long', | ||
| day: 'numeric', | ||
| hour: 'numeric', | ||
| minute: '2-digit', | ||
| hour12: true | ||
| }); | ||
| }; |
Comment on lines
+328
to
+329
| star.description?.toLowerCase().includes(starSearch.toLowerCase()) || | ||
| star.name?.toLowerCase().includes(starSearch.toLowerCase()), |
khoroshevskyi
force-pushed
the
browse_page
branch
from
294a2ac
to
9baf03d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress, but opening this PR to discuss how and whether we should update the routing for the browse page from the current
/schemassince/schemas/namespacedepends on/schemasexisting..