Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples and views API #36

Merged
merged 11 commits into from
Feb 12, 2024
Merged

Samples and views API #36

merged 11 commits into from
Feb 12, 2024

Conversation

khoroshevskyi
Copy link
Member

@khoroshevskyi khoroshevskyi commented Feb 12, 2024

In this PR was added:

  • Samples get/update/delete
  • View get/update/delete/...

Updated:

  • Request functions

  • Restructured core functions

  • Try to use it and check if everything works correctly

@khoroshevskyi khoroshevskyi changed the base branch from dev to main February 12, 2024 19:52
@khoroshevskyi khoroshevskyi changed the base branch from main to dev February 12, 2024 19:52
Copy link
Member

@nleroy917 nleroy917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, looks good otherwise

pephubclient/constants.py Show resolved Hide resolved
pephubclient/constants.py Show resolved Hide resolved
pephubclient/helpers.py Outdated Show resolved Hide resolved
pephubclient/modules/sample.py Outdated Show resolved Hide resolved
pephubclient/modules/sample.py Show resolved Hide resolved
@khoroshevskyi khoroshevskyi merged commit 435aaad into dev Feb 12, 2024
3 checks passed
@nsheff nsheff deleted the samples_views branch February 13, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants