Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code in common with projectInit #1

Open
vreuter opened this issue Aug 27, 2017 · 1 comment
Open

Code in common with projectInit #1

vreuter opened this issue Aug 27, 2017 · 1 comment
Labels
question

Comments

@vreuter
Copy link
Member

vreuter commented Aug 27, 2017

There's some functionality, e.g. in loadConfig.R and utils.R that's both here and in projectInit. Could we allow one to depend on the other? It seems like it would be projectInit depending on this...
@stolarczyk
Copy link
Member

stolarczyk commented Dec 4, 2018 •
edited
Loading

Currently there are 3 functions in utils.R that are in common.

On the other hand, the functionality of projectInit is valuable without using PEP. What is more, we don't even mention PEP concept in the vignette and documentation.

We might change that (especially with the latest addition of subproject parameter in the projectInit function) and elaborate on PEP in the docs/vignette + add the dependency. This would promote pepr, which is a benefit.

@stolarczyk stolarczyk mentioned this issue Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vreuter @stolarczyk