Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-1014: add upgrade-consistency-sharded-tls test #1384

Merged
merged 14 commits into from
Mar 26, 2024

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Nov 29, 2023

K8SPSMDB-1014 Powered by Pull Request Badge

DESCRIPTION

Problem:
We don't have an upgrade-consistency test with installed cert-manager.

Solution:
Create an upgrade-consistency-sharded-tls test. In this test, we should renew certificates after every cr update.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are the manifests (crd/bundle) regenerated if needed?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/XXL 1000+ lines label Nov 29, 2023
@pooknull pooknull marked this pull request as ready for review November 29, 2023 18:22
tplavcic
tplavcic previously approved these changes Dec 13, 2023
Copy link
Member

@tplavcic tplavcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing which I'm thinking is do we need two tests or should we just keep upgrade-consistency-sharded-tls and remove upgrade-consistency-sharded?
@hors @egegunes

@pull-request-size pull-request-size bot added size/L 100-499 lines and removed size/XXL 1000+ lines labels Mar 11, 2024
@hors hors requested a review from tplavcic March 11, 2024 13:26
@hors
Copy link
Collaborator

hors commented Mar 11, 2024

The only thing which I'm thinking is do we need two tests or should we just keep upgrade-consistency-sharded-tls and remove upgrade-consistency-sharded? @hors @egegunes

I think we need to have only one

ptankov
ptankov previously approved these changes Mar 12, 2024
@nmarukovich
Copy link
Contributor

@pooknull did you check why the test failed?

@hors hors merged commit 8719612 into main Mar 26, 2024
13 of 14 checks passed
@hors hors deleted the dev/K8SPSMDB-1014-test branch March 26, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants