K8SPSMDB-1061: Refactor reconcileStatefulSet
#1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooknull
requested review from
hors,
egegunes and
inelpandzic
as code owners
inelpandzic
reviewed
Mar 18, 2024
| if cr.Spec.Sharding.Enabled && replset.ClusterRole != api.ClusterRoleConfigSvr && replset.Name == api.ConfigReplSetName { | ||
| return reconcile.Result{}, errors.Errorf("%s is reserved name for config server replset", api.ConfigReplSetName) | ||
| return "", errors.Errorf("%s is reserved name for config server replset", api.ConfigReplSetName) |
There was a problem hiding this comment.
Since you added AppStateNone why don't you return that rather than this empty string?
There was a problem hiding this comment.
This value is ignored when an error is returned. I think it's better to not use const instead of an empty string because if AppStateNone changes in the future, we would still want to have an empty string here
pull-request-size
bot
added
size/XXL
inelpandzic
previously approved these changes
Mar 20, 2024
| return reconcile.Result{}, errors.Wrap(err, "reconcile statefulsets") | ||
| } | ||
|
|
||
| err = r.stopMongosInCaseOfRestore(ctx, cr) |
There was a problem hiding this comment.
I would put this inside of reconcileMongo since it is related to actually reconciling mongos, and plus, less lines in our Reconcile method.
egegunes
previously approved these changes
Mar 20, 2024
inelpandzic
previously approved these changes
Mar 25, 2024
pooknull
changed the title
reconcileStatefulSetreconcileStatefulSet
egegunes
previously approved these changes
Mar 26, 2024
commit: 636aa82 |
hors
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-1061
DESCRIPTION
Initially, I included it as part of a ticket, but later I found a better solution that didn't require refactoring. However, I believe that a small refactoring could still be beneficial for our code.
The main problem it aims to address is reducing the size of the
reconcileStatefulSetandReconcilemethods for theReconcilePerconaServerMongoDB.Changes in
pkg/controller/perconaservermongodb.go:Reconcilemethod code to a new method calledreconcileReplsetsgetStatefulsetFromReplsetthat returns a full statefulset based on the replset specChanges in
pkg/psmdb/statefulset.go:StatefulSpecfunctionreconcileStatefulSetmethod to theStatefulSpecfunctionpkg/psmdb/backup/agent.gothereCHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability