Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-491: Support existing cert-manager issuer #1479

Merged
merged 12 commits into from
Mar 26, 2024

Conversation

inelpandzic
Copy link
Contributor

@inelpandzic inelpandzic commented Mar 14, 2024

K8SPSMDB-491 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
PSMDB operator did not supported specifying existing cert-manager issuer.

Solution:
Add the support with adding spec.tls.issuerConf.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@@ -17,6 +17,10 @@ spec:
# tls:
# # 90 days in hours
# certValidityDuration: 2160h
# issuerConf:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inelpandzic maybe we need to have e2e test for it. We have it in PXC. Just copy a logic. @tplavcic what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hors I think the reason for have it in e2e in PXC is probably because we either couldn't test it easily with unit tests or just didn't consider it. I don't think we need to have it as a e2e test and that way just make our tests even longer.

Unit test for this case is perfectly good IMO.

tplavcic

This comment was marked as outdated.

@hors hors self-requested a review March 22, 2024 08:26
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service failure
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
recover-no-primary passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded passed
upgrade-sharded passed
users passed
version-service passed
We run 45 out of 45

commit: b7cc547
image: perconalab/percona-server-mongodb-operator:PR-1479-b7cc5471

@hors hors merged commit 08e1672 into main Mar 26, 2024
20 checks passed
@hors hors deleted the K8SPSMDB-491-cm-issuer-conf-support branch March 26, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants