-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-491: Support existing cert-manager issuer #1479
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@@ -17,6 +17,10 @@ spec: | |||
# tls: | |||
# # 90 days in hours | |||
# certValidityDuration: 2160h | |||
# issuerConf: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inelpandzic maybe we need to have e2e test for it. We have it in PXC. Just copy a logic. @tplavcic what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hors I think the reason for have it in e2e in PXC is probably because we either couldn't test it easily with unit tests or just didn't consider it. I don't think we need to have it as a e2e test and that way just make our tests even longer.
Unit test for this case is perfectly good IMO.
commit: b7cc547 |
CHANGE DESCRIPTION
Problem:
PSMDB operator did not supported specifying existing cert-manager issuer.
Solution:
Add the support with adding
spec.tls.issuerConf
.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability