-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K8SPSMDB-1000 add endpoint for Azure #1488
Conversation
if !strings.HasPrefix(stg.Azure.Container, "azure://") { | ||
if !strings.HasPrefix(stg.Azure.Container, "azure://") && stg.Azure.EndpointURL == "" { | ||
status.Destination = "azure://" + status.Destination | ||
} | ||
|
||
if !strings.HasPrefix(stg.Azure.Container, "azure://") && stg.Azure.EndpointURL != "" { | ||
status.Destination = stg.Azure.EndpointURL + "/" + status.Destination | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do this in a single if block that checks prefix and inside we can set destination according to endpoint url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok! I will recheck. thanks.
commit: 8cdd543 |
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Add to azure the possibility use custom endpoint.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability