Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K8SPSMDB-1000 add endpoint for Azure #1488

Merged
merged 7 commits into from
Mar 25, 2024
Merged

Conversation

nmarukovich
Copy link
Contributor

@nmarukovich nmarukovich commented Mar 22, 2024

K8SPSMDB-1000 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Short explanation of the problem.
Add to azure the possibility use custom endpoint.
Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

deploy/crd.yaml Show resolved Hide resolved
@nmarukovich nmarukovich requested a review from hors March 22, 2024 11:54
Comment on lines 114 to 120
if !strings.HasPrefix(stg.Azure.Container, "azure://") {
if !strings.HasPrefix(stg.Azure.Container, "azure://") && stg.Azure.EndpointURL == "" {
status.Destination = "azure://" + status.Destination
}

if !strings.HasPrefix(stg.Azure.Container, "azure://") && stg.Azure.EndpointURL != "" {
status.Destination = stg.Azure.EndpointURL + "/" + status.Destination
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do this in a single if block that checks prefix and inside we can set destination according to endpoint url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok! I will recheck. thanks.

@nmarukovich nmarukovich requested a review from egegunes March 25, 2024 08:31
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
recover-no-primary passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded passed
upgrade-sharded passed
users passed
version-service passed
We run 45 out of 45

commit: 8cdd543
image: perconalab/percona-server-mongodb-operator:PR-1488-8cdd5438

@hors hors merged commit 9ff97a7 into main Mar 25, 2024
16 checks passed
@hors hors deleted the K8SPSMDB-1000_azure_endpoint branch March 25, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants