K8SPSMDB-1055: return ErrNoOplogsForPITR
on empty oplog.Timeline
#1502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-1055
DESCRIPTION
Problem:
The first values of
.status.latestRestorableTime
inpsmdb-backup
are1970-01-01T00:00:00
. This is an incorrect value that shouldn't be set by the operator.Cause:
oplog.PITRGetValidTimelines
sometimes returns a list with emptyoplog.Timeline
(End
andStart
values are set to 0). Because of this,GetLatestTimelinePITR
returns an empty timeline, resulting in.Status.LatestRestorableTime
getting a value of1970-01-01T00:00:00
.Solution:
Operator should return
ErrNoOplogsForPITR
error on emptyoplog.Timeline
in theGetLatestTimelinePITR
method.CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability