Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-1055: return ErrNoOplogsForPITR on empty oplog.Timeline #1502

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Apr 5, 2024

K8SPSMDB-1055 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPSMDB-1055

DESCRIPTION

Problem:
The first values of .status.latestRestorableTime in psmdb-backup are 1970-01-01T00:00:00. This is an incorrect value that shouldn't be set by the operator.

Cause:
oplog.PITRGetValidTimelines sometimes returns a list with empty oplog.Timeline (End and Start values are set to 0). Because of this, GetLatestTimelinePITR returns an empty timeline, resulting in .Status.LatestRestorableTime getting a value of 1970-01-01T00:00:00.

Solution:
Operator should return ErrNoOplogsForPITR error on empty oplog.Timeline in the GetLatestTimelinePITR method.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/XS 0-9 lines label Apr 5, 2024
@pooknull pooknull marked this pull request as ready for review April 8, 2024 07:57
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr failure
pitr-sharded passed
pitr-physical passed
recover-no-primary passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 47 out of 47

commit: 908fedb
image: perconalab/percona-server-mongodb-operator:PR-1502-908fedb6

@hors hors merged commit 8536422 into main Apr 8, 2024
9 checks passed
@hors hors deleted the dev/K8SPSMDB-1055-fix branch April 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants