-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1105 change defult resource value for pbm-agent #1583
Conversation
* at least 1GB RAM is required on every node for pbm-agents to operate successfully
commit: 58b42b0 |
# memory: "0.5G" | ||
# memory: "1.2G" | ||
# requests: | ||
# cpu: "300m" | ||
# memory: "0.5G" | ||
# memory: "1G" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should set these defaults in this method if the memory is less than 1G:
func (cr *PerconaServerMongoDB) CheckNSetDefaults(platform version.Platform, log logr.Logger) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pooknull @inelpandzic We need to overwrite the user's settings. If the cluster does not have enough memory, the pod will not be started. PBM can't work correctly if it does not have enough memory.
to operate successfully
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability