-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-899: add labels to all objects #1585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
size/XL
500-999 lines
and removed
size/L
100-499 lines
labels
Jul 15, 2024
pooknull
requested review from
tplavcic,
nmarukovich,
ptankov,
jvpasinatto,
eleo007,
hors,
egegunes and
inelpandzic
as code owners
July 17, 2024 16:30
inelpandzic
previously approved these changes
Jul 18, 2024
egegunes
reviewed
Jul 18, 2024
egegunes
approved these changes
Jul 22, 2024
inelpandzic
approved these changes
Jul 22, 2024
commit: fdd2d1e |
hors
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-899
DESCRIPTION
Problem:
Some objects created by the operator don't have labels.
Solution:
Operator should add labels to all objects created by the operator.
Labels will be added to the following objects:
Also, this PR changes labels for scheduled backups (
PerconaServerMongoDBBackup
object):"ancestor": "task-name"
"percona.com/backup-ancestor": "task-name"
"cluster": "cluster1"
"percona.com/cluster": "cluster1"
"type": "cron"
"percona.com/backup-type": "cron"
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability