K8SPSMDB-1089: ignore finalizers on errors when .status.state="Error"
#1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: c838958 |
pooknull
commented
Jul 15, 2024
Comment on lines
-67
to
-77
| sts := new(appsv1.StatefulSet) | ||
| err := r.client.Get(ctx, cr.MongosNamespacedName(), sts) | ||
| if client.IgnoreNotFound(err) != nil { | ||
| return errors.Wrap(err, "failed to get mongos statefulset") | ||
| } | ||
| if sts.Spec.Replicas != nil && *sts.Spec.Replicas > 0 { | ||
| err = r.disableBalancer(ctx, cr) | ||
| if err != nil { | ||
| return errors.Wrap(err, "failed to disable balancer") | ||
| } | ||
| } |
There was a problem hiding this comment.
I removed this code, because disableBalancer doesn't do anything if cr.Spec.Sharding.Mongos.Size == 0.
egegunes
approved these changes
Jul 16, 2024
inelpandzic
approved these changes
Jul 16, 2024
hors
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPSMDB-1089
DESCRIPTION
Problem:
Cluster with error state is stuck in delete when finalizer fails.
Solution:
If the finalizer execution fails, the operator should check whether the state of the cluster is
Error. If true, then failed finalizer shouldn't be kept in the cluster.CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability