-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1224: Update images and versions for 1.19.0 release #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvpasinatto
requested review from
nmarukovich,
ptankov,
eleo007,
hors,
egegunes,
inelpandzic and
pooknull
as code owners
January 8, 2025 17:00
ptankov
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, also update the following files:
pkg/controller/perconaservermongodb/testdata/reconcile-statefulset/cfg-arbiter.yaml
pkg/controller/perconaservermongodb/testdata/reconcile-statefulset/cfg-mongod.yaml
pkg/controller/perconaservermongodb/testdata/reconcile-statefulset/cfg-nv.yaml
pkg/controller/perconaservermongodb/testdata/reconcile-statefulset/rs0-arbiter.yaml
pkg/controller/perconaservermongodb/testdata/reconcile-statefulset/rs0-mongod.yaml
pkg/controller/perconaservermongodb/testdata/reconcile-statefulset/rs0-nv.yaml
pkg/psmdb/backup/testdata/cr-with-pbm-config.yaml
eleo007
approved these changes
Jan 8, 2025
commit: bda7743 |
egegunes
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability