Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewind body filehandle before reading JSON #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 14, 2023

  1. Rewind body filehandle before reading JSON

    If something else had already read from the filehandle, we'd get
    nothing, and end up throwing an error like:
    
    ```
      [error] Caught exception in engine "Error Parsing POST 'undef',
        Error: malformed JSON string, neither tag, array, object, number,
        string or atom, at character offset 0 (before "(end of string)")
        at /home/davidp/perl5/lib/perl5/Catalyst.pm line 4092, <$fh> chunk 11."
    ```
    
    ... that sounds like we got an empty POST or something, but in fact the
    problem was that a plugin had caused the request body to have already
    been read, so the filehandle wasn't at the beginning.
    
    This seek means that we will read and parse the whole body content as
    intended, even if something had already read from the filehandle.
    
    I think this will also likely solve perl-catalyst#183.
    bigpresh committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    635b273 View commit details
    Browse the repository at this point in the history