Merge pull request #5 from permaweb/twilson63/feat-vouch-x-add-confid…

…ence-3 fix: bug with user.fields and twitter #3
permaweb · May 21, 2024 · 3fd7b1a · 3fd7b1a
2 parents 14ab97f + b038cba
commit 3fd7b1a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/server/lib/calc-confidence-value.js b/server/lib/calc-confidence-value.js
@@ -7,7 +7,7 @@ const LISTED_WEIGHT = 0.05
 export function calculate(user) {
   // calculateConfidenceValue.js
   const { followers_count, tweet_count, listed_count } = user.public_metrics;
-  const verified = user.verified ? user.verified !== 'none' : false;
+  const verified = user.verified;
 
   const confidenceValue = Math.floor((tweet_count * TWEET_WEIGHT) +
     (followers_count * FOLLOWER_WEIGHT) +

diff --git a/server/routes/x.js b/server/routes/x.js
@@ -51,7 +51,7 @@ export function callback(req, res) {
     })
     // get created at and return to client
     // 
-    const params = { 'user.fields': 'created_at' }
+    const params = { 'user.fields': 'created_at,public_metrics,verified' }
     client.get('users/me', params).then(async ({ data }) => {
       console.log(data)
       await vouch(data.created_at, req.session.address, data.username, calculate(data))

diff --git a/server/test/confidence-value.test.js b/server/test/confidence-value.test.js
@@ -9,7 +9,7 @@ test('calculate the correct confidence value for a verified user', () => {
       tweet_count: 4534,
       listed_count: 23
     },
-    verified: 'blue'
+    verified: true
   };
   const expectedValue = Math.floor((4534 * 0.001) + (1045 * 0.02) + (23 * 0.05) + 8.00);
   const confidenceValue = calculate(userMetrics);
@@ -23,7 +23,7 @@ test('calculate the correct confidence value for a non-verified user', () => {
       tweet_count: 4534,
       listed_count: 23
     },
-    verified: 'none'
+    verified: false
   };
   const expectedValue = Math.floor((4534 * 0.001) + (1045 * 0.02) + (23 * 0.05));
   const confidenceValue = calculate(userMetrics);
@@ -50,7 +50,7 @@ test('calculate the correct confidence value when some metrics are zero', () =>
       tweet_count: 0,
       listed_count: 0
     },
-    verified: 'blue'
+    verified: true
   };
   const expectedValue = 8.00;
   const confidenceValue = calculate(userMetrics);
@@ -64,7 +64,7 @@ test('calculate the correct confidence value when all metrics are zero and user
       tweet_count: 0,
       listed_count: 0
     },
-    verified: 'none'
+    verified: false
   };
   const expectedValue = 0;
   const confidenceValue = calculate(userMetrics);