Update calc-confidence-value.js #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowering followers cutoff from 100 to 10. Some real people with twitter account of less than 100 followers should be able to vouch. They will still get a low vouch value, but I think is more fair to still give them some points.
|
@simoamico94 looks like a test is failing can you take a look? |
|
#15 fixed that test here. It had the old cutoff values, that's why it failed, I've put the right values to satisfy the test description |
|
@twilson63 I think now this test should pass after the other PR has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering followers cutoff from 100 to 10. Some real people with twitter account of less than 100 followers should be able to vouch. They will still get a low vouch value, but I think is more fair to still give them some points.