Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the layout shift issue #279

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fixed the layout shift issue #279

wants to merge 2 commits into from

Conversation

khorshedcodes
Copy link

@khorshedcodes khorshedcodes commented Dec 12, 2024 •
edited by raspberri05
Loading

Description

The layout shift when clicking the profile icon was caused by this CSS style.

body[data-scroll-locked] {
    overflow: hidden !important;
    overscroll-behavior: contain;
    position: relative !important;
    padding-left: 0px;
    padding-top: 0px;
    padding-right: 0px;
    margin-left: 0;
    margin-top: 0;
    margin-right: 17px !important;
}

which is added by a library I am unaware of, to prevent this issue a CSS style is added to the global style CSS file.

Type of change

  • Bug fix

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code

@netlify Netlify
Copy link

netlify bot commented Dec 12, 2024 •
edited
Loading

✅ Deploy Preview for personafm ready!

Name Link
🔨 Latest commit c3cc3f2
🔍 Latest deploy log https://app.netlify.com/sites/personafm/deploys/675c917d568ff4000825edfb
😎 Deploy Preview https://deploy-preview-279.preview.personafm.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 69 (🔴 down 29 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Dec 12, 2024 •
edited
Loading

Here's the code health analysis summary for commits ce31e27..c3cc3f2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@khorshedcodes khorshedcodes marked this pull request as draft December 13, 2024 08:43
@raspberri05 raspberri05 linked an issue Dec 13, 2024 that may be closed by this pull request
Layout shift when clicking profile ion #241
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raspberri05 raspberri05 Awaiting requested review from raspberri05 raspberri05 is a code owner

Assignees

@raspberri05 raspberri05

@khorshedcodes khorshedcodes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout shift when clicking profile ion
2 participants
@khorshedcodes @raspberri05