Merge pull request #48 from perxhealth/feature/PX-907

Bump version number + fix conditional use of international number
perxhealth · Sep 6, 2023 · 4c4b977 · 4c4b977
2 parents 3998c7b + e619f83
commit 4c4b977
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/components/forms/PhoneInput.test.tsx b/src/components/forms/PhoneInput.test.tsx
@@ -136,7 +136,7 @@ describe("PhoneInput", () => {
         const { getByRole, getByLabelText, user } = setup()
         await user.selectOptions(getByLabelText("Select a country"), "AU")
         await user.type(getByRole("textbox"), "491570156")
-        expect(parsePhoneNumber).toHaveBeenCalledWith("+614", "AU")
+        expect(parsePhoneNumber).toHaveBeenCalledWith("4", "AU")
         expect(onChange).toHaveBeenCalledWith("+61491570156")
       })
     })
@@ -159,7 +159,7 @@ describe("PhoneInput", () => {
         const { getByRole, getByLabelText, user } = setup()
         await user.selectOptions(getByLabelText("Select a country"), "US")
         await user.type(getByRole("textbox"), "491570156")
-        expect(parsePhoneNumber).toHaveBeenCalledWith("+14", "US")
+        expect(parsePhoneNumber).toHaveBeenCalledWith("4", "US")
         expect(onChange).toHaveBeenCalledWith("+1491570156")
       })
     })

diff --git a/src/components/forms/PhoneInput.tsx b/src/components/forms/PhoneInput.tsx
@@ -115,12 +115,12 @@ export const PhoneInput = (props: PhoneInputProps) => {
 
         // Format the number as E164 and send it along
         const parsedPhoneNumber = parsePhoneNumber(
-          `${isInternational && currentCountry.callingCode}${value}`,
+          value,
           currentCountry.countryCode as LibCountryCode
         )
 
         if (onChange) {
-          onChange(parsedPhoneNumber.number)
+          onChange(isInternational ? parsedPhoneNumber.number : value)
         }
 
         if (onValidatePhoneNumber) {