Merge pull request #43 from julien-boudry/patch-1

Improve function name conversion to description
pestphp · May 5, 2024 · d481b6e · d481b6e
2 parents 8c07c1a + c99d762
commit d481b6e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Rules/ConvertTestMethod.php b/src/Rules/ConvertTestMethod.php
@@ -78,7 +78,7 @@ protected function filter(ClassMethod $classMethod): bool
     private function methodNameToDescription(string $name): string
     {
         $newName = (string) preg_replace(
-            ['/^(test|it)/', '/_/', '/(?=[A-Z])/'],
+            ['/^(test|it)/', '/(?<![A-Z]|_)(?=[A-Z])/', '/_(?<![A-Z])/'],
             ['', ' ', ' '],
             $name
         );

diff --git a/tests/Converters/CodeConverterTest.php b/tests/Converters/CodeConverterTest.php
@@ -109,6 +109,10 @@ public function test_true_is_true() {}
 
             public function testFalseIsFalse() {}
 
+            public function testPHP8() {}
+
+            public function testPHP_IS_Great() {}
+
             /** @test */
             public function it_works() {}
         }
@@ -119,6 +123,8 @@ public function it_works() {}
     expect($convertedCode)
         ->toContain("test('true is true', function () {")
         ->toContain("test('false is false', function () {")
+        ->toContain("test('php8', function () {")
+        ->toContain("test('php is great', function () {")
         ->toContain("it('works', function () {")
         ->not->toContain('/** @test */');
 });