Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ActiveSupport usage delegate #78

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

Bhacaz
Copy link
Collaborator

@Bhacaz Bhacaz commented Feb 13, 2024

If activesupport is not loaded, running AggregateExamples may cause problem since it was using delegate from activesupport.

The delegate version was automaticly changed by Rubocop with a Rails cop (which I disabled in this PR)

Orignal version: https://github.com/test-prof/test-prof/blob/02d8f355c158fb021e58ff1327d624a8299762b6/lib/test_prof/cops/rspec/language.rb#L26-L28

❯ be rubocop
undefined method `delegate' for RuboCop::Cop::RSpec::AggregateExamples::Language::SelectorSet:Class
Did you mean?  DelegateClass
/Users/jfbastien/.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/rubocop-petal-1.3.0/lib/rubocop/cop/rspec/aggregate_examples/language.rb:27:in `<class:SelectorSet>'
/Users/jfbastien/.rbenv/versions/2.7.8/lib/ruby/gems/2.7.0/gems/rubocop-petal-1.3.0/lib/rubocop/cop/rspec/aggregate_examples/language.rb:14:in `<module:Language>'

@Bhacaz Bhacaz marked this pull request as ready for review February 13, 2024 13:50
@Bhacaz Bhacaz requested a review from ericproulx February 13, 2024 13:50
@Bhacaz Bhacaz merged commit 756a8cf into main Feb 13, 2024
1 check passed
@Bhacaz Bhacaz deleted the remove_usage_of_active_support_delegate branch February 13, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants