Added buffers::string_view_buffer #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-winter
approved these changes
Feb 6, 2024
|
Thanks for the effort. It all looked ok so I merged it. |
Closed
|
Although now I think you could have updated the documentation as well. If you don't mind mention it in the Buffers section in the Various Features. |
|
I will get to it now, sorry for the oversight. Is it possible to reopen the PR, so that I can add commits to it, or should I just make another one? |
|
Create a new one. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've read the issue #45, but I noticed @hrco159753 never made a pull request;
I've implemented the same feature, by simply copy-pasting the
string_bufferclass, replacing strings with string_views and adding two test cases.