Skip to content

Commit

Permalink
test: rebase 후 실패하는 테스트 수정
Browse files Browse the repository at this point in the history
  • Loading branch information
Combi153 committed Feb 5, 2024
1 parent 58397b4 commit a927542
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import java.util.Date
class AuthControllerTest(
private val memberRepository: MemberRepository,
private val refreshTokenRepository: RefreshTokenRepository,
private val authTokenProvider: AuthTokenProvider,
) : ApiTestConfig() {

init {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import io.restassured.module.kotlin.extensions.Extract
import io.restassured.module.kotlin.extensions.Given
import io.restassured.module.kotlin.extensions.Then
import io.restassured.module.kotlin.extensions.When
import org.springframework.http.HttpHeaders
import org.springframework.http.HttpStatus.NO_CONTENT
import org.springframework.http.HttpStatus.OK
import org.springframework.http.MediaType
Expand All @@ -28,7 +27,7 @@ class WishProductControllerTest(

init {
Given("찜 상품 수정을") {
val memberAuthResponse = signInAsMember()
val accessToken = signInAsMember().accessToken
val product = productRepository.save(product())
val request = UpdateWishRequest(
productId = product.id
Expand All @@ -38,7 +37,7 @@ class WishProductControllerTest(
val response = Given {
log().all()
.body(request)
.header(HttpHeaders.AUTHORIZATION, memberAuthResponse.accessToken)
.auth().preemptive().oauth2(accessToken)
.contentType(MediaType.APPLICATION_JSON_VALUE)
} When {
post("/products/wishes")
Expand All @@ -55,25 +54,26 @@ class WishProductControllerTest(
}

Given("찜 목록 조회를") {
val memberAuthResponse = signInAsMember()
val accessToken = signInAsMember().accessToken
val memberId = getMemberIdByAccessToken(accessToken)
val store = storeRepository.save(store())
val (product1, product2, product3) = saveProducts(productRepository, store)
wishProductRepository.save(
WishProduct(
productId = product1.id,
memberId = getMemberIdFromAuthResponse(memberAuthResponse)
memberId = memberId
)
)
wishProductRepository.save(
WishProduct(
productId = product2.id,
memberId = getMemberIdFromAuthResponse(memberAuthResponse)
memberId = memberId
)
)
wishProductRepository.save(
WishProduct(
productId = product3.id,
memberId = getMemberIdFromAuthResponse(memberAuthResponse)
memberId = memberId
)
)

Expand All @@ -82,7 +82,7 @@ class WishProductControllerTest(
log().all()
.param("lastViewedId", -1L)
.param("limit", 20)
.header(HttpHeaders.AUTHORIZATION, memberAuthResponse.accessToken)
.auth().preemptive().oauth2(accessToken)
} When {
get("/products/wishes")
} Then {
Expand Down
9 changes: 5 additions & 4 deletions src/test/kotlin/com/petqua/test/ApiTestConfig.kt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.petqua.test

import com.petqua.domain.auth.token.AuthTokenProvider
import com.petqua.presentation.auth.AuthExtractor
import com.petqua.presentation.auth.AuthResponse
import com.petqua.test.config.OauthTestConfig
import io.kotest.core.spec.style.BehaviorSpec
Expand All @@ -27,7 +27,8 @@ abstract class ApiTestConfig() : BehaviorSpec() {
private lateinit var dataCleaner: DataCleaner

@Autowired
protected lateinit var authTokenProvider: AuthTokenProvider
protected lateinit var authExtractor: AuthExtractor


init {
this.beforeTest {
Expand All @@ -39,8 +40,8 @@ abstract class ApiTestConfig() : BehaviorSpec() {
}
}

final fun getMemberIdFromAuthResponse(authResponse: AuthResponse): Long {
return authTokenProvider.getAccessTokenClaimsOrThrow(authResponse.accessToken).memberId
final fun getMemberIdByAccessToken(accessToken: String): Long {
return authExtractor.getAccessTokenClaimsOrThrow(accessToken).memberId
}

final fun signInAsMember(): AuthResponse {
Expand Down

0 comments on commit a927542

Please sign in to comment.