Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgo641
reviewed
Apr 22, 2024
src/main/kotlin/com/petqua/application/product/review/ProductReviewImageUploader.kt
Show resolved
Hide resolved
src/main/kotlin/com/petqua/application/product/review/ProductReviewImageUploader.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/petqua/presentation/product/ProductReviewController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/petqua/common/converter/MultipartJackson2HttpMessageConverter.kt
Show resolved
Hide resolved
src/main/kotlin/com/petqua/application/image/ImageStorageService.kt
Outdated
Show resolved
Hide resolved
Comment on lines
28
to
29
| val pathIndex = storedUrl.indexOf("/$path") | ||
| return "$domain${storedUrl.substring(pathIndex)}" |
There was a problem hiding this comment.
이미지 경로에 대한 조작이 여러번 발생하는데, 주석으로 예시를 들어주실 수 있나요?
storedUrl -> pathIndex -> $domain + ${storedUrl에서 자른 문자열} 과정
-> https://s3.amazonaws.com/my-imgae/myfolder/image.png
-> 도메인이 끝나는 지점의 인덱스 (com)
-> domain + /my-imgae/myfolder/image.png
=> petqua.com/my-imgae/myfolder/image.png
이런과정이죠?
아니면 이미지경로를 만드는 역할을 분리해도 좋아보입니다.
There was a problem hiding this comment.
주석으로 예시를 달아두었습니다! 그리고 이미지 경로를 변환하는 책임을 지는 객체를 하나 추가해두었습니다.
예시는 말씀하신 바와 정확히 일치합니다!
src/test/kotlin/com/petqua/application/product/review/ProductReviewFacadeServiceTest.kt
Outdated
Show resolved
Hide resolved
Combi153
force-pushed
the
125-feature-상품입양-후기-작성
branch
from
ec0b55b
to
085c182
Compare
hgo641
approved these changes
Apr 29, 2024
TaeyeonRoyce
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📁 작업 설명
📸 작업화면
설명