Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: 공지사항 조회 #20

Merged
merged 9 commits into from
Jan 27, 2024
Merged

feature: 공지사항 조회 #20

merged 9 commits into from
Jan 27, 2024

Conversation

TaeyeonRoyce
Copy link
Member

@TaeyeonRoyce TaeyeonRoyce commented Jan 25, 2024 •
edited
Loading

📌 관련 이슈

📁 작업 설명

  • 공지 사항 조회 API 개발

기타

- on #18

@TaeyeonRoyce TaeyeonRoyce self-assigned this Jan 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 25, 2024 •
edited
Loading

Test Results

 9 files  +2   9 suites  +2   2s ⏱️ ±0s
24 tests +3  24 ✅ +3  0 💤 ±0  0 ❌ ±0 
26 runs  +3  26 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 62c298e. ± Comparison against base commit 69cd895.

♻️ This comment has been updated with latest results.

@TaeyeonRoyce TaeyeonRoyce marked this pull request as ready for review January 26, 2024 10:23
Combi153
Combi153 approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@Combi153 Combi153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 깔끔해서 리뷰할만한 것이 없군요!
고생하셨습니다 😎

src/main/kotlin/com/petqua/domain/announcement/Announcement.kt Outdated
Comment on lines 19 to 23
@CreatedDate
val createAt: LocalDateTime = LocalDateTime.now(), // TODO: BaseEntity 상속

@LastModifiedDate
val updateAt: LocalDateTime = LocalDateTime.now(), // TODO: BaseEntity 상속
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 적용하실 수 있지 않나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉 cherrypick만 하고 누락되었네요..! 수정하겠습니다~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

62c298e
반영 완료!

src/test/kotlin/com/petqua/application/product/ProductServiceTest.kt
@@ -1,6 +1,5 @@
package com.petqua.application
package com.petqua.application.product
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헉쓰 놓쳤네요 이동 감사합니다

src/test/kotlin/com/petqua/test/ApiTestConfig.kt
Comment on lines +20 to +23
this.beforeTest {
RestAssured.port = this.port
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오호 이전이랑 무슨 차이가 있나요??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전에는 port라는 변수에 값만 설정하고, port를 사용하진 않았었는데요
protected val port: Int = RestAssured.port

@SpringBooTest에서 RandomPort로 하니까 RestAssured.port 값이 이전과 동일해서 connection 안되더라고요.

@LocalServerPort로 SpringContext마다 할당된 randomPort를 RestAssured.port로 지정하였습니다!
Int 타입이라 Lateinit이 안되어서 기본값을 하나 두었어요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너모 멋져요...!

src/main/kotlin/com/petqua/application/announcement/AnnouncementService.kt
Comment on lines +8 to +20
@Transactional
@Service
class AnnouncementService(
private val announcementRepository: AnnouncementRepository,
) {

@Cacheable("announcements")
@Transactional(readOnly = true)
fun readAll(): List<AnnouncementResponse> {
val announcements = announcementRepository.findAll()
return announcements.map { AnnouncementResponse.from(it) }
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요~~

hgo641
hgo641 approved these changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@hgo641 hgo641 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔꼼합니다...👍

@TaeyeonRoyce TaeyeonRoyce merged commit 8ab5b18 into develop Jan 27, 2024
2 checks passed
@TaeyeonRoyce TaeyeonRoyce deleted the 19-feature-공지사항-조회 branch January 27, 2024 09:14
hgo641 pushed a commit that referenced this pull request Jan 28, 2024
@TaeyeonRoyce @hgo641
feature: 공지사항 조회 (#20)
c339d31 
* feat: Announcement 도메인 추가

* feat: Announcement 조회 로직 추가

* feat: Announcement 조회 API 추가

* style: method, dto naming 수정

* test: 공지사항 조회 api test 추가

* refactor: 불필요한 응답 필드 제거

* test: test 패키지 이동

* test: ProductControllerTest에 ApiTestConfig 적용

* refactor: BaseEntity 적용
hgo641 pushed a commit that referenced this pull request Jan 29, 2024
@TaeyeonRoyce @hgo641
feature: 공지사항 조회 (#20)
8ff8506 
* feat: Announcement 도메인 추가

* feat: Announcement 조회 로직 추가

* feat: Announcement 조회 API 추가

* style: method, dto naming 수정

* test: 공지사항 조회 api test 추가

* refactor: 불필요한 응답 필드 제거

* test: test 패키지 이동

* test: ProductControllerTest에 ApiTestConfig 적용

* refactor: BaseEntity 적용
hgo641 pushed a commit that referenced this pull request Jan 29, 2024
@TaeyeonRoyce @hgo641
feature: 공지사항 조회 (#20)
e6af73a 
* feat: Announcement 도메인 추가

* feat: Announcement 조회 로직 추가

* feat: Announcement 조회 API 추가

* style: method, dto naming 수정

* test: 공지사항 조회 api test 추가

* refactor: 불필요한 응답 필드 제거

* test: test 패키지 이동

* test: ProductControllerTest에 ApiTestConfig 적용

* refactor: BaseEntity 적용
hgo641 pushed a commit that referenced this pull request Jan 29, 2024
@TaeyeonRoyce @hgo641
feature: 공지사항 조회 (#20)
51ee25d 
* feat: Announcement 도메인 추가

* feat: Announcement 조회 로직 추가

* feat: Announcement 조회 API 추가

* style: method, dto naming 수정

* test: 공지사항 조회 api test 추가

* refactor: 불필요한 응답 필드 제거

* test: test 패키지 이동

* test: ProductControllerTest에 ApiTestConfig 적용

* refactor: BaseEntity 적용
hgo641 added a commit that referenced this pull request Jan 29, 2024
@hgo641
feature: 소셜 로그인 구현 (#17)
718870c 
* feat: OauthClient 생성

* feat: KakaoOauthClient 생성

* feat: OauthService 생성

* feat: OauthController 생성

* refactor: OauthController URI 변경

* refactor: 공백 라인 추가

* feat: OauthClientException 추가

* refactor: OauthClient 인터페이스에 requestToken 메서드 추가

* refactor: OauthUserInfo를 data class로 변경

* refactor: 사용하지 않는 필드 제거

* chore: 패키지 분리 및 코드 포맷 수정

* chore: 코드 포맷 수정

* feat: JWTProvider 생성

* feat: OauthClientExceptionType을 주입받게 변경

* chore: 어노테이션 순서 변경

* feat: OauthServerType에 필드 추가

* feat: Member 생성

* feat: AuthToken, AuthTokenProvider 생성

* refactor: 클래스명 변경

* feat: OAuth 로그인 기능 구현

* feat: refreshToken 설정 추가

* refactor: 패키지 이름 변경

* refactor: KakaoOauthProperties 위치 변경

* feature: 공지사항 조회 (#20)

* refactor: 토큰 발급 날짜를 인자로 받게 변경

* test: OauthController 테스트 추가

* test: OauthService 테스트 추가

* test: AuthTokenProvider 테스트 추가

* chore: 중복 주석 삭제

* chore: 사용하지 않는 코드 삭제

* feat: AuthCode 요청 리다이렉트 기능 추가

* refactor: AccessTokenClaims를 사용한 토큰 생성 기능 추가

* refactor: 토큰 복호화시 AccessTokenClaims 형태로 반환하게 변경

* feat: 멤버의 Authority 생성

* refactor: AuthException 이름 변경 및 예외 타입 추가

* feat: 멤버 접근 권한 검증 로직 추가

* refactor: 패키지 분리

* refactor: 인덱싱 오퍼레이터로 변경

* feature: cors 관련 설정을 추가한다 (#24)

* chore: test 프로퍼티 설정 추가

* chore: 코드 스타일 적용

* refactor: 패키지 이동

* refactor: 트랜잭셔널 추가
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Combi153 Combi153 Combi153 approved these changes

@hgo641 hgo641 hgo641 approved these changes

Assignees

@TaeyeonRoyce TaeyeonRoyce

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: 공지사항 조회
3 participants
@TaeyeonRoyce @hgo641 @Combi153