Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id = 1L 인 경우, EntityManger에 의해 동일한 Entity로 판별하여 insert가 되지 않고 update됨
TaeyeonRoyce
force-pushed
the
28-feature-봉달-목록-조회-api
branch
from
2802e9b
to
cae10d1
Compare
hgo641
approved these changes
Feb 2, 2024
src/main/kotlin/com/petqua/application/cart/CartProductService.kt
Outdated
Show resolved
Hide resolved
Comment on lines
74
to
89
| fun fromDeletedProduct(cartProduct: CartProduct): CartProductResponse { | ||
| return CartProductResponse( | ||
| id = cartProduct.id, | ||
| storeName = "", | ||
| productId = cartProduct.productId, | ||
| productName = "", | ||
| productThumbnailUrl = "", | ||
| productPrice = 0, | ||
| productDiscountRate = 0, | ||
| productDiscountPrice = 0, | ||
| quantity = cartProduct.quantity.value, | ||
| isMale = cartProduct.isMale, | ||
| deliveryMethod = cartProduct.deliveryMethod.name, | ||
| isOnSale = false, | ||
| ) | ||
| } |
There was a problem hiding this comment.
이거 디자인이 아직 안정해졌다고 해서 임의로 보내는 값인가요?.?
There was a problem hiding this comment.
이 경우에는 [품절]로 표기 하신다고 했어요!
client 입장에서 봉달 목록 data를 한번에 조회하게 되는데 품절인 상품과 그렇지 않은 상품의 응답 스키마가 달라지면 복잡해질 것 같더라고요.
그래서 그냥 임의 데이터로 채워 넣고 isOnSale로 품절 여부를 판단할 수 있게 두었습니다!
| @Transactional(readOnly = true) | ||
| fun readAll(memberId: Long): List<CartProductResponse> { | ||
| memberRepository.existByIdOrThrow(memberId, MemberException(NOT_FOUND_MEMBER)) | ||
| val cartProducts = cartProductRepository.findAllByMemberId(memberId) |
There was a problem hiding this comment.
헛 저 찜 목록 조회할 때 이거까지 한 번에 조인해서 가져오게했는데, 혹시 cartProducts를 미리 조회해오신 이유가 있으신가요?
There was a problem hiding this comment.
Product가 제거된 cartProduct가 조회 되지 않을 것 같아서 분리했었습니다.
근데 outer join 하고 product가 null인 걸로 삭제 판단해도 될 것 같네요!
커넥션을 줄이는 방향으로 수정해보겠습니다!
| productRepository.deleteById(productAId) | ||
| val results = cartProductService.readAll(memberId) | ||
|
|
||
| Then("빈 리스트를 반환 한다") { |
Combi153
approved these changes
Feb 2, 2024
Comment on lines
83
to
93
| @Transactional(readOnly = true) | ||
| fun readAll(memberId: Long): List<CartProductResponse> { | ||
| memberRepository.existByIdOrThrow(memberId, MemberException(NOT_FOUND_MEMBER)) | ||
| val cartProducts = cartProductRepository.findAllByMemberId(memberId) | ||
| val products = productByIds(cartProducts) | ||
| val findAll = productRepository.findAll() | ||
| return cartProducts.map { | ||
| products[it.id]?.let { product -> CartProductResponse.of(it, product) } | ||
| ?: CartProductResponse.fromDeletedProduct(it) | ||
| } | ||
| } |
There was a problem hiding this comment.
장바구니 전체 가격은 클라이언트에서 계산하는 걸까요?
There was a problem hiding this comment.
이 부분도 협의해보고 적용하겠습니다!
Comment on lines
+101
to
+111
| val query = jpql { | ||
| selectNew<ProductResponse>( | ||
| entity(Product::class), | ||
| path(Store::name) | ||
| ).from( | ||
| entity(Product::class), | ||
| join(Store::class).on(path(Product::storeId).eq(path(Store::id))), | ||
| ).where( | ||
| predicateByIds(ids) | ||
| ) | ||
| } |
There was a problem hiding this comment.
멋지게 잘 쓰셨네요!
혹시 데이터 순서도 명시하면 어떨까요?
| @@ -177,6 +177,22 @@ class ProductCustomRepositoryImplTest( | |||
| } | |||
| } | |||
|
|
|||
| Given("다중 id로 ProductResponse를 조회 할 때") { | |||
Comment on lines
377
to
387
| When("봉달에 담은 상품이 삭제 되면") { | ||
| productRepository.delete(productA) | ||
| val response = requestReadAllCartProducts(memberAuthResponse.accessToken) | ||
|
|
||
| Then("삭제된 상품은 구매 불가능 하도록 조회된다") { | ||
| val responseBody = response.`as`(Array<CartProductResponse>::class.java) | ||
|
|
||
| assertSoftly(response) { | ||
| statusCode shouldBe HttpStatus.OK.value() | ||
| responseBody.size shouldBe 3 | ||
| responseBody.find { it.productId == productA.id }!!.isOnSale shouldBe false |
Combi153
approved these changes
Feb 2, 2024
Comment on lines
30
to
32
| ).where( | ||
| path(CartProduct::memberId).eq(memberId) | ||
| ) |
There was a problem hiding this comment.
o..or..orderBy 해주시면 안될까요..ㅎㅎ
There was a problem hiding this comment.
5a50036 최신순으로 반영하였습니다!
Comment on lines
+57
to
+66
| storeName = storeName ?: "", | ||
| productId = product?.id ?: 0L, | ||
| productName = product?.name ?: "", | ||
| productThumbnailUrl = product?.thumbnailUrl ?: "", | ||
| productPrice = product?.price?.intValueExact() ?: 0, | ||
| productDiscountRate = product?.discountRate ?: 0, | ||
| productDiscountPrice = product?.discountPrice?.intValueExact() ?: 0, | ||
| quantity = cartProduct.quantity.value, | ||
| isMale = cartProduct.isMale, | ||
| deliveryMethod = cartProduct.deliveryMethod.name, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📁 작업 설명
봉달에 담겨 있는 상품 조회 API 구현
간접 참조로 되어 있는 product를 조회하기 위해
findAllProductResponseByIdIn()을 추가 했습니다.테스트 fixture 개선
fixture에서
id = 1L로 지정하다 보니 생성하고 저장할 때 동일한 객체로 판단해서 update 쿼리가 날아가는 이슈를 겪었습니다.. 수정했어요! 948eaf8기타
- on #37