refactor: lastViewedId default 값 설정 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgo641
approved these changes
Feb 3, 2024
| val adjustedLimit = if (limit > LIMIT_CEILING) LIMIT_CEILING else limit | ||
| return ProductPaging(lastViewedId, adjustedLimit + PADDING_FOR_PAGING) | ||
| return ProductPaging(adjustedLastViewedId, adjustedLimit + PADDING_FOR_PAGING) |
There was a problem hiding this comment.
늦은 리뷰인데...ㅋㅋ...
혹시 PADDGING_FOR_PAGING이 필요한 이유 설명 부탁드려도 될까요.............ㅎㅎ.......... 🙇♀️🙇♀️🙇♀️
There was a problem hiding this comment.
클라이언트가 limit으로 20개를 요청했다고 가정할게요.
서버는 클라이언트에게 20개의 데이터를 보내면서 다음 페이지가 존재하는지 여부를 함께 응답해요. 만약 다음 페이지가 존재하는지 여부를 알려주지 않는다면, 클라이언트 입장에서는 데이터가 반환되지 않는 것이 데이터가 더 이상 없기 때문인지, 아니면 서버에 문제가 생겼기 때문이지 파악할 수 없기 때문이에요.
이때 다음 페이지가 존재하는지 알기 위해 저는 limit 20 에서 padding 1을 더해서, 총 21개의 데이터를 DB에서 읽어오도록 설정했어요.
만약 DB에서 꺼낸 데이터가 21개라면 다음 페이지가 있다고 판단하면 되고 20개 이하라면 다음 페이지가 없다고 판단하면 되니까요. 그때 사용되는 값이 PADDING_FOR_PAGING 입니다!
TaeyeonRoyce
approved these changes
Feb 6, 2024
Combi153
force-pushed
the
45-refactor-페이지네이션-lastviewedid-default-값-설정
branch
from
00b5b59
to
32ce9ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
📁 작업 설명