Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 무중단배포 적용 #83

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

hgo641
Copy link
Contributor

@hgo641 hgo641 commented Feb 16, 2024

📌 관련 이슈

📁 작업 설명

무중단 배포 적용했습니다!

  • 헬스 체크용 url 지정
  • deploy-prod.yml 수정

Copy link
Member

@TaeyeonRoyce TaeyeonRoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무중단 배포 플로우 좋네요!👍👍

여러 sh들에 대해서 하나의 파일로 관리하고, sh 파일을 실행하는 방식은 어떠신가요?
workflows에 노출되어 있어서 보안상으로도 안좋고, 관리하기도 어려울 것 같다는 생각이 들어서요!

@@ -31,6 +31,9 @@ dependencies {
implementation("org.springframework.boot:spring-boot-starter-web")
implementation("org.springframework.boot:spring-boot-starter-webflux")

// actuator
implementation("org.springframework.boot:spring-boot-starter-actuator:3.2.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Combi153 Combi153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 로이스 의견에 동의합니다!
sh 파일을 따로 만들어 관리하고 workflow 에서는 그걸 실행하면 좋을 것 같아요!
하드코딩은 아닐지 걱정하셨던 부분을 sh 파일 분리로 충분히 해결하실 수 있을 것 같습니다

@@ -31,6 +31,9 @@ dependencies {
implementation("org.springframework.boot:spring-boot-starter-web")
implementation("org.springframework.boot:spring-boot-starter-webflux")

// actuator
implementation("org.springframework.boot:spring-boot-starter-actuator:3.2.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@green-kong
Copy link

무중단배포 하면 홍고, 홍고 하면 무중단배포

Copy link

Test Results

 29 files  ±0   29 suites  ±0   10s ⏱️ ±0s
138 tests ±0  138 ✅ ±0  0 💤 ±0  0 ❌ ±0 
183 runs  ±0  183 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7f34980. ± Comparison against base commit 45eaafe.

Copy link
Contributor

@Combi153 Combi153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ec2 로 구경가겠습니다~

@hgo641 hgo641 merged commit e47b962 into develop Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: 무중단 배포 적용
4 participants