-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: 무중단배포 적용 #83
The head ref may contain hidden characters: "79-feature-\uBB34\uC911\uB2E8\uBC30\uD3EC"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
무중단 배포 플로우 좋네요!👍👍
여러 sh들에 대해서 하나의 파일로 관리하고, sh 파일을 실행하는 방식은 어떠신가요?
workflows에 노출되어 있어서 보안상으로도 안좋고, 관리하기도 어려울 것 같다는 생각이 들어서요!
@@ -31,6 +31,9 @@ dependencies { | |||
implementation("org.springframework.boot:spring-boot-starter-web") | |||
implementation("org.springframework.boot:spring-boot-starter-webflux") | |||
|
|||
// actuator | |||
implementation("org.springframework.boot:spring-boot-starter-actuator:3.2.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 로이스 의견에 동의합니다!
sh 파일을 따로 만들어 관리하고 workflow 에서는 그걸 실행하면 좋을 것 같아요!
하드코딩은 아닐지 걱정하셨던 부분을 sh 파일 분리로 충분히 해결하실 수 있을 것 같습니다
@@ -31,6 +31,9 @@ dependencies { | |||
implementation("org.springframework.boot:spring-boot-starter-web") | |||
implementation("org.springframework.boot:spring-boot-starter-webflux") | |||
|
|||
// actuator | |||
implementation("org.springframework.boot:spring-boot-starter-actuator:3.2.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
무중단배포 하면 홍고, 홍고 하면 무중단배포 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ec2 로 구경가겠습니다~
📌 관련 이슈
📁 작업 설명
무중단 배포 적용했습니다!