Enhancements to Fluid Handling Module #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- *Docstrings*: Added docstrings to functions and classes to explain their purpose and usage. - *Type Annotations*: Added type annotations to function parameters and return values for better clarity. - *Consistent Naming*: Used consistent naming conventions throughout the code. - *Fluid Aliases*: Consolidated the aliases for each fluid into a dictionary for better readability and maintenance. - *Simplified Logic*: Simplified the logic in the normalize_mix function to make it more straightforward. - *Error Handling*: Improved error handling in the get_fluid_name function to raise informative errors when the fluid name is not found. These improvements enhance the readability, maintainability, and robustness of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request introduces several enhancements to the fluid handling module:
normalize_mixfunction to make it more intuitive and efficient.get_fluid_namefunction to provide informative messages when a fluid name is not found.These improvements aim to elevate the readability, maintainability, and robustness of the fluid handling module specifically for Petrobras applications.