Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds to test_requires #193

Merged
merged 8 commits into from
Apr 29, 2024
Merged

Adds to test_requires #193

merged 8 commits into from
Apr 29, 2024

Conversation

prabhatnagarajan
Copy link
Contributor

@prabhatnagarajan prabhatnagarajan commented Apr 3, 2024 •
edited
Loading

The tests use scipy and optuna, so I include them in the test_requires. I have linked in comments to the places where they are used in the tests.

@github-actions github-actions bot requested a review from muupan April 3, 2024 05:19
prabhatnagarajan
prabhatnagarajan commented Apr 3, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@muupan
Copy link
Member

muupan commented Apr 29, 2024

/test

@pfn-ci-bot
Copy link

Successfully created a job for commit 949e068:

muupan
muupan approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@muupan muupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! It seems like the CI errors are not due to this PR.

@muupan muupan merged commit 580ac4f into pfnet:master Apr 29, 2024
6 of 7 checks passed
@prabhatnagarajan prabhatnagarajan deleted the test_requires branch April 29, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muupan muupan muupan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prabhatnagarajan @muupan @pfn-ci-bot