From 6a9f758b976e008510c47e71bbab302152edb1c4 Mon Sep 17 00:00:00 2001 From: Prabhat Date: Thu, 15 Sep 2022 15:36:04 -0600 Subject: [PATCH 1/6] tries to fix issue --- pfrl/wrappers/atari_wrappers.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pfrl/wrappers/atari_wrappers.py b/pfrl/wrappers/atari_wrappers.py index dcde73ad8..1b1ce8e77 100644 --- a/pfrl/wrappers/atari_wrappers.py +++ b/pfrl/wrappers/atari_wrappers.py @@ -37,7 +37,8 @@ def reset(self, **kwargs): if self.override_num_noops is not None: noops = self.override_num_noops else: - if gym.__version__ >= "0.24.0": + gym_version = StrictVersion(gym.__version__) + if gym_version >= StrictVersion("0.24.0"): noops = self.unwrapped.np_random.integers(1, self.noop_max + 1) else: noops = self.unwrapped.np_random.randint(1, self.noop_max + 1) From e8be1816b116a4e55df49dbff6ee7f69849ee79a Mon Sep 17 00:00:00 2001 From: Prabhat Date: Thu, 15 Sep 2022 15:47:30 -0600 Subject: [PATCH 2/6] using packaging version --- pfrl/wrappers/atari_wrappers.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pfrl/wrappers/atari_wrappers.py b/pfrl/wrappers/atari_wrappers.py index 1b1ce8e77..28fb13d47 100644 --- a/pfrl/wrappers/atari_wrappers.py +++ b/pfrl/wrappers/atari_wrappers.py @@ -7,6 +7,7 @@ import gym import numpy as np from gym import spaces +from packaging import version import pfrl @@ -37,8 +38,8 @@ def reset(self, **kwargs): if self.override_num_noops is not None: noops = self.override_num_noops else: - gym_version = StrictVersion(gym.__version__) - if gym_version >= StrictVersion("0.24.0"): + gym_version = version.parse(gym.__version__) + if gym_version >= ersion.parse("0.24.0"): noops = self.unwrapped.np_random.integers(1, self.noop_max + 1) else: noops = self.unwrapped.np_random.randint(1, self.noop_max + 1) From e66d5a03b401955564d900b438b046b4b29965f0 Mon Sep 17 00:00:00 2001 From: Prabhat Date: Thu, 15 Sep 2022 15:48:52 -0600 Subject: [PATCH 3/6] minor bug fix --- pfrl/wrappers/atari_wrappers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pfrl/wrappers/atari_wrappers.py b/pfrl/wrappers/atari_wrappers.py index 28fb13d47..57164b476 100644 --- a/pfrl/wrappers/atari_wrappers.py +++ b/pfrl/wrappers/atari_wrappers.py @@ -39,7 +39,7 @@ def reset(self, **kwargs): noops = self.override_num_noops else: gym_version = version.parse(gym.__version__) - if gym_version >= ersion.parse("0.24.0"): + if gym_version >= version.parse("0.24.0"): noops = self.unwrapped.np_random.integers(1, self.noop_max + 1) else: noops = self.unwrapped.np_random.randint(1, self.noop_max + 1) From 05ed45667e1683d46b5049cc41a432be80a62766 Mon Sep 17 00:00:00 2001 From: Prabhat Date: Thu, 15 Sep 2022 15:50:53 -0600 Subject: [PATCH 4/6] updates version to match ours --- pfrl/wrappers/atari_wrappers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pfrl/wrappers/atari_wrappers.py b/pfrl/wrappers/atari_wrappers.py index 57164b476..c8fd49ce8 100644 --- a/pfrl/wrappers/atari_wrappers.py +++ b/pfrl/wrappers/atari_wrappers.py @@ -39,7 +39,7 @@ def reset(self, **kwargs): noops = self.override_num_noops else: gym_version = version.parse(gym.__version__) - if gym_version >= version.parse("0.24.0"): + if gym_version >= version.parse("0.21.0"): noops = self.unwrapped.np_random.integers(1, self.noop_max + 1) else: noops = self.unwrapped.np_random.randint(1, self.noop_max + 1) From d2130027e2829bd00eb532eef46a207dcc8cd4ac Mon Sep 17 00:00:00 2001 From: Prabhat Nagarajan Date: Tue, 2 Apr 2024 23:16:40 -0600 Subject: [PATCH 5/6] Adds scipy and optuna to test_requires --- setup.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/setup.py b/setup.py index 33a2babf4..7794a64b8 100644 --- a/setup.py +++ b/setup.py @@ -12,6 +12,8 @@ test_requires = [ 'pytest', + 'scipy', + 'optuna', 'attrs<19.2.0', # pytest does not run with attrs==19.2.0 (https://github.com/pytest-dev/pytest/issues/3280) # NOQA ] From 949e068a9a54ca2aed51a29d2f1d8a6ee7a80920 Mon Sep 17 00:00:00 2001 From: Prabhat Nagarajan Date: Tue, 2 Apr 2024 23:28:02 -0600 Subject: [PATCH 6/6] Update setup.py --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 7794a64b8..47a5e4ef2 100644 --- a/setup.py +++ b/setup.py @@ -5,7 +5,7 @@ install_requires = [ 'torch>=1.3.0', 'gym>=0.9.7', - 'numpy>=1.11.0', + 'numpy>=1.10.4', 'pillow', 'filelock', ]