Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto review assignment for PRs from forks #62

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

muupan
Copy link
Member

@muupan muupan commented Sep 4, 2020

See kentaro-m/auto-assign-action#29

Without this change, auto-assign-action fails to assign reviewers to PRs from forked repositories. Confirmed on: #54

With this change, it can assign reviewers to such PRs. Confirmed on: #61

Use pull_request_target so that it applies to PRs from forks
@muupan
Copy link
Member Author

muupan commented Sep 4, 2020

I don't know why it does not work for this particular PR, but I guess it will work after this PR is merged considering #61 (with a PR to pull_request_target branch, not master) worked.

Copy link
Contributor

@marioyc marioyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan muupan merged commit 0292261 into master Sep 4, 2020
@muupan muupan deleted the pull_request_target branch September 4, 2020 01:57
@muupan muupan added this to the v0.2.0 milestone Dec 14, 2020
@muupan muupan added the testing Changes related to testing/reviewing/CI label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Changes related to testing/reviewing/CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants