Single responsibility principle for the SchemaView and DataGridView #7884

asheshv · 2024-08-31T02:02:36Z

A class should have one, and only one, reason to change.
-- Robert C. Martin (Uncle Bob)

Single responsibility principle improves the code maintainability, because:

Frequency and Effects of Changes - you need to change block for code for a single purpose.
Easier to Understand - improves the readability
Easy to extend - easy to add new features

Current implementation of the SchemaView and DataGridView is amazing. It is great piece of code, and does the job well.
But - at the same time, it's not easy to understand, and it is not easy to make change in it, as it could result into breaking other places as well.

When working on the 'useSchemaState' custom hook, I realised that - it is not easy or enough to move some piece of the code and introduce it as the custom hook, the current javascript and feature test-suites have definitely informed me about the broken state at a particular point of time. it made me realised that it won't be easy to introduce new features or do modification in future.

As a result - I would like to propose to use the single responsibility principle for them.

Note: There are still some exceptions in the currently proposed patch.

References:

The text was updated successfully, but these errors were encountered:

yogeshmahajan-1903 · 2024-09-10T08:09:28Z

Issues found -
1.In preferences, try to set default binary path > crash

2.Try adding new row in server properties > connection parameter > crash

3.In connection parameters, values for files parameters like ssl, folder icon is missing also not horizontal scrollable.

connection' dialog (QueryTool). (Reference: pgadmin-org#7884)

asheshv · 2024-09-10T13:04:47Z

All issues are fixed in the PR [#7910].

* Show the icon for the 'Reset' button. (Reference #7884) * Reload the server list after connecting to a server in the 'New connection' dialog (QueryTool). (Reference: #7884) * Pass the grid path during the bulk update (click on a radio action) * Don't assign the cell value to the 'rowValue' variable.

yogeshmahajan-1903 · 2024-09-11T12:20:54Z

1.In connection parameters, values for files parameters like ssl, folder icon is missing also not horizontal scrollable.

Expected -

2.Dropdown is not populated for value change.

Expected -

3.Value is missing if value is switch type

Expected -

4.Values in the backup/restore etc dialogue are in single column

Expected -

is loaded asynchronously, and variable types data may not be available while rendering the 'value' cell. (Fixes pgadmin-org#7884)

…g#7884)

yogeshmahajan-1903 · 2024-09-12T06:19:34Z

New issues -
1.select database > Navigate to properties panel > Something went wrong.(For any db object)

2.An empty column is added in columns list in nested grid control for the constraints -

3.Unable to create the function

4.Unable to create Azure cloud instance. When auth method is as Azure CLI and user click s on 'Click here to authenticate yourself ..'. Nothing is happening.

akshay-joshi · 2024-09-12T06:29:03Z

New Connection Dialog: Role list is empty

anilsahoo20 · 2024-09-12T07:32:58Z

Filtered rows for a table don't have the initial focus when it opens.

anilsahoo20 · 2024-09-12T11:15:14Z

Table>Constraints>Foreign key>Columns>Referencing dropdown is empty after selecting References dropdown. This is for Table object and ERD tool table dialog.

RohitBhati8269 · 2024-09-12T11:54:15Z

Select any Server -> Backup Globals
This dialog filename input is missing warning:-
Version 8.10

current version:-

RohitBhati8269 · 2024-09-18T11:50:14Z

While creating the Trigger function unable to edit the code tab section:-

If it is disabled for specific languages then it should not show the error message.

RohitBhati8269 · 2024-09-18T12:02:55Z

current:-

version 8.10:-

asheshv · 2024-09-18T12:11:36Z

With exclude constraint, if one exclude constraint is added, if we want to create more exclude constraints by adding columns or expression, then the add button is disabled.

Fixed in the PR [7942]

RohitBhati8269 · 2024-09-18T12:37:16Z

Strict? switch/toggle is showing as clickable when hovering the mouse on that but no action is performed when clicking on the switch/toggle.

asheshv · 2024-09-18T13:22:16Z

While creating the Trigger function unable to edit the code tab section:-

If it is disabled for specific languages then it should not show the error message.

This is an old issue, but - fixed it.

asheshv · 2024-09-18T14:38:49Z

Strict? switch/toggle is showing as clickable when hovering the mouse on that but no action is performed when clicking on the switch/toggle.

Fixed

asheshv · 2024-09-18T14:39:14Z

current:-

version 8.10:-

Fixed

asheshv · 2024-09-18T17:02:40Z

Found new issue: Open Create table dialog. Add some columns, go to Constraints tab. Columns control is disabled in Primary and Unique key constraints.

This issue is also reproducible in ERD tool.

Fixed

asheshv · 2024-09-18T17:03:02Z

Found new issue:

Columns are not selected in the Publication dialog. Open Publication Dialog. Add any table and try to select the column from the drop-down.

Fixed

anilsahoo20 · 2024-09-19T05:27:12Z

Found new issue: Open Create table dialog. Add some columns, go to Constraints tab. Columns control is disabled in Primary and Unique key constraints.

This issue is still reproducible in snapshot build.

anilsahoo20 · 2024-09-19T05:44:27Z

On create table>constraints>exclude, When we add 1st constraint, its being added, and when we add another exclude constraint with multiple columns, getting , , ,

anilsahoo20 · 2024-09-19T05:47:54Z

On Create Table>Constraints>Foreign key, when select the local column, references and referencing, and click on add button, it adds a row with empty brackets as per screenshot

akshay-joshi · 2024-09-19T06:13:54Z

Found new issue:

Columns are not selected in the Publication dialog. Open Publication Dialog. Add any table and try to select the column from the drop-down.

This issue is still reproducible in snapshot build.

anilsahoo20 · 2024-09-19T07:25:18Z

Once we add the exclusion constraints, on enabling the expression switch it holds the old value.

anilsahoo20 · 2024-09-19T07:27:56Z

Once we add the initial foreign key in the constraints of create table, the subsequent foreign key constraints are not showing.
Getting error on submitting, errormsg: "'references'"

anilsahoo20 · 2024-09-19T07:34:00Z

Found new issue:
Columns are not selected in the Publication dialog. Open Publication Dialog. Add any table and try to select the column from the drop-down.

This issue is still reproducible in snapshot build.

This issue is fixed in PR, #7944

anilsahoo20 · 2024-09-19T07:36:18Z

Found new issue: Open Create table dialog. Add some columns, go to Constraints tab. Columns control is disabled in Primary and Unique key constraints.

This issue is still reproducible in snapshot build.

This issue is fixed in PR, #7944

anilsahoo20 · 2024-09-19T07:44:48Z

current:-

version 8.10:-

This issue is fixed in PR. #7944

anilsahoo20 · 2024-09-19T07:46:05Z

Strict? switch/toggle is showing as clickable when hovering the mouse on that but no action is performed when clicking on the switch/toggle.

This issue is reproducible.

anilsahoo20 · 2024-09-19T08:08:33Z

While creating the Trigger function unable to edit the code tab section:-

If it is disabled for specific languages then it should not show the error message.

When I select other languages than C in Create tigger function>Definition, the error is not showing and code tab is editable, if I select C, the code mirror cursor is not showing and is not editable and error is not showing, but disabled grey color is not showing, attaching the screenshot for reference.

anilsahoo20 · 2024-09-19T08:16:42Z

With exclude constraint, if one exclude constraint is added, if we want to create more exclude constraints by adding columns or expression, then the add button is disabled.

This issue is still reproducible.

anilsahoo20 · 2024-09-19T08:34:37Z

Strict? switch/toggle is showing as clickable when hovering the mouse on that but no action is performed when clicking on the switch/toggle.

This issue is reproducible.

These disabled controls are for EPAS>=9.6 and lanname=edbspl. Tested with EPAS server, controls are working fine.

asheshv · 2024-09-19T09:40:07Z

While creating the Trigger function unable to edit the code tab section:-
If it is disabled for specific languages then it should not show the error message.

When I select other languages than C in Create tigger function>Definition, the error is not showing and code tab is editable, if I select C, the code mirror cursor is not showing and is not editable and error is not showing, but disabled grey color is not showing, attaching the screenshot for reference.

Yes - this expected.
I have marked the code as readonly instead of setting 'visible' option to 'false'.

anilsahoo20 · 2024-09-19T10:19:08Z

While creating the Trigger function unable to edit the code tab section:-
If it is disabled for specific languages then it should not show the error message.

When I select other languages than C in Create tigger function>Definition, the error is not showing and code tab is editable, if I select C, the code mirror cursor is not showing and is not editable and error is not showing, but disabled grey color is not showing, attaching the screenshot for reference.

Yes - this expected. I have marked the code as readonly instead of setting 'visible' option to 'false'.

Okay

anilsahoo20 · 2024-09-19T10:19:25Z

With exclude constraint, if one exclude constraint is added, if we want to create more exclude constraints by adding columns or expression, then the add button is disabled.

This issue is still reproducible.

Issue is fixed.

anilsahoo20 · 2024-09-19T10:34:54Z

Issue found in user management dialog,

on adding a new user, the error continues to display, email can not be empty, and the save button is not enabled after entering all the mandatory fields.
Also the search box takes the full width, but it has taken half width.
The search box is not giving any result on searching the users that are still present.

yogeshmahajan-1903 · 2024-09-20T04:24:56Z

1.Scroll is added in the parameters - [Sev-3]

Expected -

2.In User management search box still takes the full width, but it has taken half width. [sev-3]

3.The search box is still not giving any result on searching the users that are still present. [sev-3]

adityatoshniwal · 2024-09-20T04:45:25Z

Note is missing text:

anilsahoo20 · 2024-09-23T08:18:17Z

Tested and verified on candidate build: https://developer.pgadmin.org/builds/2024-09-20-1/
Package: arm64
Environment: macOs Ventura 13.5.1

asheshv assigned asheshv, akshay-joshi and adityatoshniwal and unassigned asheshv Aug 31, 2024

asheshv added Housekeeping javascript Pull requests that update Javascript code labels Aug 31, 2024

khushboovashi added the EDB Sprint 176 label Sep 6, 2024

akshay-joshi added this to the 8.12 milestone Sep 9, 2024

akshay-joshi unassigned akshay-joshi and adityatoshniwal Sep 10, 2024

asheshv added a commit to asheshv/pgadmin4 that referenced this issue Sep 10, 2024

Show the icon for the 'Reset' button. (Reference pgadmin-org#7884)

badf874

asheshv added a commit to asheshv/pgadmin4 that referenced this issue Sep 10, 2024

Reload the server list after connecting to a server in the 'New

12d47c4

connection' dialog (QueryTool). (Reference: pgadmin-org#7884)

asheshv assigned akshay-joshi and yogeshmahajan-1903 Sep 10, 2024

anilsahoo20 assigned anilsahoo20 and unassigned akshay-joshi and yogeshmahajan-1903 Sep 11, 2024

akshay-joshi added EDB Sprint 177 and removed EDB Sprint 176 labels Sep 11, 2024

asheshv added a commit to asheshv/pgadmin4 that referenced this issue Sep 12, 2024

Don't rely on the 'optionsLoaded' for setting the variable types as it

610ba99

is loaded asynchronously, and variable types data may not be available while rendering the 'value' cell. (Fixes pgadmin-org#7884)

asheshv added a commit to asheshv/pgadmin4 that referenced this issue Sep 12, 2024

Fixed a type while checking for the 'inline-group'. fixes (pgadmin-or…

3bfa2cb

…g#7884)

anilsahoo20 closed this as completed Sep 23, 2024

Single responsibility principle for the SchemaView and DataGridView #7884

Single responsibility principle for the SchemaView and DataGridView #7884

Comments

asheshv commented Aug 31, 2024 • edited Loading

yogeshmahajan-1903 commented Sep 10, 2024

asheshv commented Sep 10, 2024

yogeshmahajan-1903 commented Sep 11, 2024

yogeshmahajan-1903 commented Sep 12, 2024 • edited Loading

akshay-joshi commented Sep 12, 2024

anilsahoo20 commented Sep 12, 2024

anilsahoo20 commented Sep 12, 2024

RohitBhati8269 commented Sep 12, 2024

RohitBhati8269 commented Sep 18, 2024 • edited Loading

RohitBhati8269 commented Sep 18, 2024

asheshv commented Sep 18, 2024 • edited Loading

RohitBhati8269 commented Sep 18, 2024 • edited Loading

asheshv commented Sep 18, 2024

asheshv commented Sep 18, 2024

asheshv commented Sep 18, 2024

asheshv commented Sep 18, 2024

asheshv commented Sep 18, 2024

anilsahoo20 commented Sep 19, 2024 • edited Loading

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

akshay-joshi commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024 • edited Loading

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024 • edited Loading

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

asheshv commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

anilsahoo20 commented Sep 19, 2024

yogeshmahajan-1903 commented Sep 20, 2024 • edited Loading

adityatoshniwal commented Sep 20, 2024

anilsahoo20 commented Sep 23, 2024

asheshv commented Aug 31, 2024 •

edited

Loading

yogeshmahajan-1903 commented Sep 12, 2024 •

edited

Loading

RohitBhati8269 commented Sep 18, 2024 •

edited

Loading

asheshv commented Sep 18, 2024 •

edited

Loading

RohitBhati8269 commented Sep 18, 2024 •

edited

Loading

anilsahoo20 commented Sep 19, 2024 •

edited

Loading

anilsahoo20 commented Sep 19, 2024 •

edited

Loading

anilsahoo20 commented Sep 19, 2024 •

edited

Loading

yogeshmahajan-1903 commented Sep 20, 2024 •

edited

Loading