Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User management dialog search is not working. #7958

Closed
anilsahoo20 opened this issue Sep 23, 2024 · 3 comments
Closed

User management dialog search is not working. #7958

anilsahoo20 opened this issue Sep 23, 2024 · 3 comments
Assignees
@pravesh-sharma
Labels
Bug EDB Sprint 178
Milestone
8.13

Comments

@anilsahoo20
Copy link
Contributor

anilsahoo20 commented Sep 23, 2024 •
edited
Loading

Please note that security bugs or issues should be reported to security@pgadmin.org.

Describe the bug

  1. The search box takes the full width, but it has taken half width.
  2. The search box is not giving any result on searching the users that are still present.
  3. Note is missing in Existing table>Edit dialog>Partitions tab.

Screenshots
Screenshot 2024-09-19 at 5 25 55 PM

Screenshot 2024-09-23 at 2 33 55 PM
@yogeshmahajan-1903
Copy link
Contributor

1.Scroll is added in the parameters - [Sev-3]
Screenshot 2024-09-20 at 9 53 48 AM

Expected -
Screenshot 2024-09-20 at 9 53 53 AM

@anilsahoo20 anilsahoo20 changed the title User management dialog search is not working along with other issues after SchemaView change. User management dialog search is not working. Sep 23, 2024
@asheshv
Copy link
Contributor

asheshv commented Sep 23, 2024 •
edited
Loading

PR#7959
This has not taken care of the Dashboard issue as it is not really related to SchemaView changes.

@akshay-joshi akshay-joshi added this to the 8.13 milestone Sep 24, 2024
akshay-joshi pushed a commit that referenced this issue Oct 1, 2024
@asheshv
Fixed issues reported in #7958
15c37b6 
* Fixed issues reported in #7954

- Search wasn't working as we were using the wrong row-index, while
  rendering it.
- Fixed the CSS issue with the alignment of the search input box.
- Pass the row object while rendering the 'DataRow' component, to
  improve the performance as it repeatedly calls the filtering function for each row.
- Changed the order of the validators on a field to prioritize the
  'empty' string validator over the unique-id validator in a
  collection.
- Use 'row.index' instead of rowId, while rendering a grid row
@pravesh-sharma pravesh-sharma self-assigned this Oct 3, 2024
@pravesh-sharma
Copy link
Contributor

Issue fixed verified on snapshot build.

Env:
OS - macOS 14.7 (Sonoma)
Mode - Desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pravesh-sharma pravesh-sharma

Labels
Bug EDB Sprint 178
Projects
Current Sprint (178)
Status: ✅ Done
Milestone
8.13
Development

No branches or pull requests
5 participants
@akshay-joshi @asheshv @yogeshmahajan-1903 @pravesh-sharma @anilsahoo20