-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the extendability of the SchemaView and DataGridView. #7876
Commits on Aug 29, 2024
-
Improved the extendability fo the SchemaView and DataGridView.
Restructured these modules for ease of mainteance and apply the single responsibilty principle (wherever is applicable). * SchemaView - Split the code based on the functionality, and responsibility. - Introduced a new View 'InlineView' instead of using the 'nextInline' configuration of the fields to have a better, and manageable view. - Using the separate class 'SchemaState' for managing the data and states of the SchemaView (separated from the 'useSchemaState' custom hook). - Introduced three new custom hooks 'useFieldValue', 'useFieldOptions', 'useFieldError' for the individual control to use for each Schema Field. - Don't pass value as the parameter props, and let the 'useFieldValue' and other custom hooks to decide, wheather to rerender the control itself or the whole dialog/view. (single responsibilty principle) - Introduced a new data store with subscription facility. - Moving the field metadata (option) evaluation to separate place for better management, and each option can be defined for a particular kind of field (for example - colleciton, row, cell, general, etc). - Allow to provide custom control for all kind of Schema field. * DataGridView - Same as SchemaView, split the DataGridView call in smaller and manageable chunks. (For example - grid, row, mappedCell, etc). - Use context based approach for providing the row and table data instead of passing them as parameter to each and every component separately. - Have a facility to extend this feature separately in future. (for example - selecatable cell, column grouping, etc.) - Separated the features like deletable, editable, reorder, expandable etc. cells using the above feature support. - Added ability to provide the CustomHeader, and CustomRow through the Schema field, which will extend the ability to customisation better. - Removed the 'DataGridViewWithHeaderForm' as it has been achieved through providing 'CustomHeader', and also introduced 'DataGridFormHeader' (a custom header) to achieve the same feature as 'DataGridViewWithHeaderForm'. Also - Modified the testcases to use separate 'Schema' objects for testing the rendering of create, edit, and properties mode as BaseUISchema instance share the same SchemaState object.
Configuration menu - View commit details
-
Copy full SHA for 997fba1 - Browse repository at this point
Copy the full SHA 997fba1View commit details -
Provide the name of the view during the registration as production co…
…de will mangled the name of the component function, which would lead to 'View not found' error.
Configuration menu - View commit details
-
Copy full SHA for 91c5843 - Browse repository at this point
Copy the full SHA 91c5843View commit details
Commits on Aug 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 664e9da - Browse repository at this point
Copy the full SHA 664e9daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9588f15 - Browse repository at this point
Copy the full SHA 9588f15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 044931d - Browse repository at this point
Copy the full SHA 044931dView commit details -
Pass the reset key to 'FormView' from SchemaDialogView, and set the
reset the tab only, when reset key is changed.
Configuration menu - View commit details
-
Copy full SHA for ab2e467 - Browse repository at this point
Copy the full SHA ab2e467View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c80dd9 - Browse repository at this point
Copy the full SHA 4c80dd9View commit details
Commits on Sep 2, 2024
-
Used 'origData' variable to get the initiail data for validation of
the data. I never realised that - we were using 'origData' for schema validation to get the initial data, and replaced it with 'sessData' variable by mistake. Changing it back to use 'origData' based on the feedback from Aditya.
Configuration menu - View commit details
-
Copy full SHA for 3ff9916 - Browse repository at this point
Copy the full SHA 3ff9916View commit details -
Keep the value of the input-box locally as well to solve the caret
jumping issue. It fixes pgadmin-org#7878. Reference: - https://dev.to/kwirke/solving-caret-jumping-in-react-inputs-36ic
Configuration menu - View commit details
-
Copy full SHA for 1ed674f - Browse repository at this point
Copy the full SHA 1ed674fView commit details -
Fixed the review comments shared by Aditya.
TODO:: Yet to work on the issues for the partition and table dialog UI.
Configuration menu - View commit details
-
Copy full SHA for 3fe575b - Browse repository at this point
Copy the full SHA 3fe575bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 740d9c6 - Browse repository at this point
Copy the full SHA 740d9c6View commit details
Commits on Sep 3, 2024
-
Introduce the 'useFieldSchema' custom hook to calculate the 'visible'
option for the field having no 'id'. e.g. a field with type 'nested-tab', 'nested-fieldset'.
Configuration menu - View commit details
-
Copy full SHA for 8188504 - Browse repository at this point
Copy the full SHA 8188504View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce7f90 - Browse repository at this point
Copy the full SHA 2ce7f90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 971c895 - Browse repository at this point
Copy the full SHA 971c895View commit details -
Configuration menu - View commit details
-
Copy full SHA for e905991 - Browse repository at this point
Copy the full SHA e905991View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee522f6 - Browse repository at this point
Copy the full SHA ee522f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f840198 - Browse repository at this point
Copy the full SHA f840198View commit details -
Configuration menu - View commit details
-
Copy full SHA for c909e0a - Browse repository at this point
Copy the full SHA c909e0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 490b9e5 - Browse repository at this point
Copy the full SHA 490b9e5View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d5f56c9 - Browse repository at this point
Copy the full SHA d5f56c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b87ca9b - Browse repository at this point
Copy the full SHA b87ca9bView commit details
Commits on Sep 5, 2024
-
Use a table level schema for the PgTable to use showing the expanded
row details. It fixes the dashboard issue, where activity table was showing same query for all the rows. [pgadmin-org#7895]
Configuration menu - View commit details
-
Copy full SHA for 21972d8 - Browse repository at this point
Copy the full SHA 21972d8View commit details -
Fix the query tool restore connection issue on the server disconnecti…
…on from the left side object explorer. pgadmin-org#6502
Configuration menu - View commit details
-
Copy full SHA for 490bb24 - Browse repository at this point
Copy the full SHA 490bb24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ec6cf5 - Browse repository at this point
Copy the full SHA 6ec6cf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a7211 - Browse repository at this point
Copy the full SHA 77a7211View commit details -
Configuration menu - View commit details
-
Copy full SHA for b06b466 - Browse repository at this point
Copy the full SHA b06b466View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d7b9ce - Browse repository at this point
Copy the full SHA 8d7b9ceView commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15d97de - Browse repository at this point
Copy the full SHA 15d97deView commit details