Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added feature to auto detect the OS end-of-line (EOL) character.#7393 #7887

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Added feature to auto detect the OS end-of-line (EOL) character.#7393 #7887

merged 1 commit into from
Sep 24, 2024

Conversation

RohitBhati8269
Copy link
Contributor

Detail :- #7393

@adityatoshniwal adityatoshniwal self-assigned this Sep 2, 2024
adityatoshniwal
adityatoshniwal requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@adityatoshniwal adityatoshniwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Delay the tooltip visibility. It is annoying when trying to switch.
  2. When copying the text, crlf is not respected.
  3. Copy a crlf text from outside and paste in query tool. It should change based on current EOL. Vice-versa.

web/pgadmin/tools/sqleditor/static/js/components/QueryToolConstants.js Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/StatusBar.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/StatusBar.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/StatusBar.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/StatusBar.jsx Outdated Show resolved Hide resolved
adityatoshniwal
adityatoshniwal requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@adityatoshniwal adityatoshniwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will commit a fix for status CSS issue. Update the screenshot again.

docs/en_US/query_tool_toolbar.rst Outdated Show resolved Hide resolved
docs/en_US/query_tool_toolbar.rst Outdated Show resolved Hide resolved
docs/en_US/query_tool_toolbar.rst Outdated Show resolved Hide resolved
web/pgadmin/static/js/components/ReactCodeMirror/CustomEditorView.js Outdated Show resolved Hide resolved
web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/Query.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/StatusBar.jsx Outdated Show resolved Hide resolved
adityatoshniwal
adityatoshniwal requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@adityatoshniwal adityatoshniwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any code related to detecting a files EOL. OS level EOL is not enough. A file with only CRLF can be opened on a Mac env.

web/pgadmin/tools/sqleditor/static/js/components/sections/StatusBar.jsx Outdated Show resolved Hide resolved
web/pgadmin/tools/sqleditor/static/js/components/sections/StatusBar.jsx Outdated Show resolved Hide resolved
@adityatoshniwal adityatoshniwal merged commit 4cb0f87 into pgadmin-org:master Sep 24, 2024
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityatoshniwal adityatoshniwal adityatoshniwal requested changes

Assignees

@adityatoshniwal adityatoshniwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RohitBhati8269 @adityatoshniwal