Fixes the Variable Schema UI issues and InlineView bug reported in (#7884) #7913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
asheshv
commented
Sep 12, 2024
asheshv
commented
- Load the variable types as soon as they're available, and do not rely on the 'optionsLoaded' as they would loaded asynchronously, and the variable types data may not be available while rendering the 'value' cell for the existing parameters.
- Fixed a type while checking for the 'inline-group'.
connection' dialog (QueryTool). (Reference: pgadmin-org#7884)
is loaded asynchronously, and variable types data may not be available while rendering the 'value' cell. (Fixes pgadmin-org#7884)
to force reload the control on value change for one of the dependencies.
subscriber mananager instance. It helps multiple subscribers in a single control as we could have multiple subscribe within a control. (For example - value, options, errors, etc).
asheshv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.