Merge pull request dmdorman#1621 from phBalance/phBalance/scss-guardi…

…ng-cleanup

refactor(scss): start to make explicit what is hero override vs unique

scss/components/foundry-overrides/_dice.scss

@@ -0,0 +1,30 @@
+// These all override FoundryVTT basic styling
+.dice-roll {
+    .dice-total {
+        &.success {
+            color: inherit;
+            background: #c7d0c0;
+            border: 1px solid #006c00;
+        }
+
+        &.failure {
+            color: inherit;
+            background: #fdd;
+            border: 1px solid #6e0000;
+        }
+
+        &.critical {
+            color: green;
+        }
+
+        &.fumble {
+            color: red;
+        }
+    }
+
+    .dice-rolls .roll {
+        &.calculated {
+            background-image: url("../icons/circle.svg");
+        }
+    }
+}

scss/herosystem6e.scss

@@ -11,6 +11,9 @@
 @use "global/grid";
 @use "global/flex";
 
+/* Styles for dice which are direct overrides of FoundryVTT styling */
+@include meta.load-css("components/foundry-overrides/dice");
+
 /* Styles limited to hero sheets */
 .hero {
     @include meta.load-css("components/forms");
@@ -26,11 +29,6 @@
 
 @include meta.load-css("components/chat");
 
-/* Styles for dice */
-.dice-roll {
-    @include meta.load-css("components/dice");
-}
-
 /* Styles for time tracking */
 @include meta.load-css("components/time");