Skip to content

Commit

Permalink
Fixing some linting issues.
Browse files Browse the repository at this point in the history
  • Loading branch information
emarinier committed Apr 8, 2024
1 parent 1ee013e commit 995f296
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 14 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/linting_comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Download lint results
uses: dawidd6/action-download-artifact@v2
uses: dawidd6/action-download-artifact@f6b0bace624032e30a85a8fd9c1a7f8f611f5737 # v3
with:
workflow: linting.yml
workflow_conclusion: completed
Expand All @@ -21,7 +21,7 @@ jobs:
run: echo "pr_number=$(cat linting-logs/PR_number.txt)" >> $GITHUB_OUTPUT

- name: Post PR comment
uses: marocchino/sticky-pull-request-comment@v2
uses: marocchino/sticky-pull-request-comment@331f8f5b4215f0445d3c07b4967662a32a2d3e31 # v2
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
number: ${{ steps.pr_number.outputs.pr_number }}
Expand Down
7 changes: 2 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
.nextflow*
work/
/data/
data/
results/
.DS_Store
testing/
testing*
*.pyc
*.swp
/.nf-test
/.nf-test.log
ids.csv
*.swp
4 changes: 4 additions & 0 deletions .nf-core.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ lint:
- .github/workflows/awstest.yml
- .github/workflows/awsfulltest.yml
- CODE_OF_CONDUCT.md
- lib/Utils.groovy
- lib/WorkflowMain.groovy
- lib/NfcoreTemplate.groovy
- lib/WorkflowIridanextexample.groovy
files_unchanged:
- assets/sendmail_template.txt
- assets/email_template.html
Expand Down
Binary file removed lib/nfcore_external_java_deps.jar
Binary file not shown.
19 changes: 12 additions & 7 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
# Config file for Python. Mostly used to configure linting of bin/check_samplesheet.py with Black.
# Config file for Python. Mostly used to configure linting of bin/*.py with Ruff.
# Should be kept the same as nf-core/tools to avoid fighting with template synchronisation.
[tool.black]
[tool.ruff]
line-length = 120
target_version = ["py37", "py38", "py39", "py310"]
target-version = "py38"
cache-dir = "~/.cache/ruff"

[tool.isort]
profile = "black"
known_first_party = ["nf_core"]
multi_line_output = 3
[tool.ruff.lint]
select = ["I", "E1", "E4", "E7", "E9", "F", "UP", "N"]

[tool.ruff.lint.isort]
known-first-party = ["nf_core"]

[tool.ruff.lint.per-file-ignores]
"__init__.py" = ["E402", "F401"]

0 comments on commit 995f296

Please sign in to comment.