Skip to content

Commit

Permalink
Merge branch 'development'
Browse files Browse the repository at this point in the history
  • Loading branch information
apetkau committed Oct 26, 2022
2 parents 0088d49 + 4e2e245 commit 3f32f49
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Version 0.9.1

* Fixed a bug that occured when parsing some plasmid FASTA record IDs.
* Fixed a bug that occured when parsing some plasmid FASTA record IDs ([PR 159](https://github.com/phac-nml/staramr/pull/159)).
* Fixed issue where sometimes the extraction of error messages from `makeblastdb` was crashing leading to less useful errors ([PR 160](https://github.com/phac-nml/staramr/pull/160)).

# Version 0.9.0

Expand Down
4 changes: 3 additions & 1 deletion staramr/blast/JobHandler.py
Original file line number Diff line number Diff line change
Expand Up @@ -286,5 +286,7 @@ def _make_blast_db(self, path: str, file: str) -> None:
subprocess.run(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, check=True)
except subprocess.CalledProcessError as e:
err_msg = str(e.stderr.strip())
err_msg = re.findall('REF\|(.*?)\'', err_msg)[0]
err_msg_match = re.findall('REF\|(.*?)\'', err_msg)
if len(err_msg_match) > 0:
err_msg = err_msg_match[0]
raise Exception('Could not run makeblastdb on file {}, error {}'.format(file, err_msg))

0 comments on commit 3f32f49

Please sign in to comment.