Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2138 Implement derive_vars_extreme_event() #2236

Merged
merged 31 commits into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
60a0cba
Chore #2138 Implement derive_vars_extreme_event()
jeffreyad Nov 15, 2023
6c5ee52
Merge branch 'main' into 2138_Implement_derive_vars_extreme_event
jeffreyad Nov 15, 2023
d670044
#2138 run styler
jeffreyad Nov 16, 2023
f967254
#2138 update documentation after styler and edit for derive_extreme().
jeffreyad Nov 16, 2023
8e514c3
#2138 add lb data to derive_vars_extreme_event() example
jeffreyad Nov 16, 2023
dee0f83
#2138 Update test coverage for event$order
jeffreyad Nov 20, 2023
34ad1a3
#2138 Run styler on test file
jeffreyad Nov 20, 2023
b35e566
Merge branch 'main' into 2138_Implement_derive_vars_extreme_event
jeffreyad Nov 20, 2023
d54f7ed
#2138 minor updates to documentation
jeffreyad Nov 21, 2023
5757799
#2138 remove derive_extreme() function. Call derive_extreme_event() …
jeffreyad Nov 21, 2023
36646f9
#2138 run styler
jeffreyad Nov 21, 2023
dbf4094
#2138 Add DTHCAUS example
jeffreyad Nov 21, 2023
280c845
Merge branch 'main' into 2138_Implement_derive_vars_extreme_event
jeffreyad Nov 22, 2023
07a3c39
#2138 updates from feedback
jeffreyad Nov 23, 2023
fb8f45a
#2138 update example code
jeffreyad Nov 23, 2023
c79eff2
#2138 Update to set_values_to
jeffreyad Nov 27, 2023
70c52b0
Merge branch 'main' into 2138_Implement_derive_vars_extreme_event
jeffreyad Nov 27, 2023
e488508
#2138 update LSTALVDT in ADSL template and vignette
jeffreyad Nov 27, 2023
69c15b6
Merge branch 'main' into 2138_Implement_derive_vars_extreme_event
jeffreyad Nov 27, 2023
67aae52
#2138 Update DTHCAUS in ADSL vignette
jeffreyad Nov 27, 2023
802a6af
#2138 simplify new_vars call in ADSL
jeffreyad Nov 28, 2023
e3c9543
#2138 Simplify new_vars in example
jeffreyad Nov 28, 2023
384b686
#2138 Simplify new_vars in example
jeffreyad Nov 28, 2023
91d4e66
Merge branch 'main' into 2138_Implement_derive_vars_extreme_event
jeffreyad Nov 28, 2023
dbac2db
#2138 doc updates
jeffreyad Nov 28, 2023
0e0df93
#2138 Split files
jeffreyad Nov 28, 2023
fce2932
#2138 run styler on new test files
jeffreyad Nov 28, 2023
9cfe58f
#2138 set_values_to default NULL
jeffreyad Nov 29, 2023
5b3c9e1
#2138 set_values_to default NULL
jeffreyad Nov 29, 2023
fe12854
#2138 doc: filter to filter_join argument
jeffreyad Nov 29, 2023
6554b90
#2138 remove set_values_to call from derive_vars_extreme_event()
jeffreyad Nov 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export(default_qtc_paramcd)
export(derivation_slice)
export(derive_basetype_records)
export(derive_expected_records)
export(derive_extreme)
export(derive_extreme_event)
export(derive_extreme_records)
export(derive_locf_records)
Expand Down Expand Up @@ -106,6 +107,7 @@ export(derive_vars_dtm_to_dt)
export(derive_vars_dtm_to_tm)
export(derive_vars_duration)
export(derive_vars_dy)
export(derive_vars_extreme_event)
export(derive_vars_joined)
export(derive_vars_merged)
export(derive_vars_merged_lookup)
Expand Down
8 changes: 4 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@

## New Features

New global option created `signif_digits` to handle floating point issue, the value is
set to `15`, and is used with the `base R` function `signif()` when comparing 2 numeric
values. This is implemented in `admiral ` functions `derive_var_atoxgr_dir()` and `derive_var_anrind()`. (#2134)
- Implement `derive_vars_extreme_event()`, which works as `derive_extreme_event()` but returns variables instead of a parameter. (#2138)
bms63 marked this conversation as resolved.
Show resolved Hide resolved
bundfussr marked this conversation as resolved.
Show resolved Hide resolved

For more information, please see blog: [How admiral handles floating points](https://pharmaverse.github.io/blog/posts/2023-10-30_floating_point/floating_point.html)
- New global option created `signif_digits` to handle floating point issue, the value is set to `15`, and is used with the `base R` function `signif()` when comparing 2 numeric values. This is implemented in `admiral ` functions `derive_var_atoxgr_dir()` and `derive_var_anrind()`. (#2134)
- For more information, please see blog: [How admiral handles floating points](https://pharmaverse.github.io/blog/posts/2023-10-30_floating_point/floating_point.html)

## Updates of Existing Functions

Expand Down Expand Up @@ -125,6 +124,7 @@ order = exprs(my_order_var),
- `derive_var_ontrtfl(span_period)`

- The `derive_param_extreme_record()` function has been superseded in favor of `derive_extreme_event()`. (#2141)
- The functions `derive_var_dthcaus()`, `derive_var_extreme_dt()`, and `derive_var_extreme_dtm()` are superseded in favor of `derive_vars_extreme_event()`. (#2138)

## Documentation

Expand Down
Loading
Loading