Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to close 233 - iRecist vignette initial draft #265

Merged
merged 21 commits into from
Dec 13, 2023
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8f5210f
233 - iRecist vignette initial draft
vinhn23 Nov 9, 2023
33bbce6
Merge branch 'main' into 233_iRECIST_vignette_main
bundfussr Nov 9, 2023
b85bdef
Merge branch '256_admiral_updates' into 233_iRECIST_vignette_main
bundfussr Nov 9, 2023
70e5350
233 - irecist vignette review update 1
vinhn23 Nov 15, 2023
10f3aa4
233 - iRECIST vignette - addressed 1st round comments
vinhn23 Nov 20, 2023
91b8316
Merge branch '233_iRECIST_vignette_main' of github.com:pharmaverse/ad…
bundfussr Nov 21, 2023
169bcb6
233 - iRECIST vignette - 2nd round comments
vinhn23 Nov 28, 2023
9ffd0d7
#233 iRECIST_vignette_main: add handling of RECIST/iRECIST mixture
bundfussr Nov 29, 2023
45cfaca
Merge branch '233_iRECIST_vignette_main' of github.com:pharmaverse/ad…
bundfussr Nov 29, 2023
fee44c3
#233 iRECIST_vignette_main: fix links
bundfussr Nov 29, 2023
4e15d52
#233 iRECIST_vignette_main: fix spelling
bundfussr Nov 29, 2023
ff65905
#233 iRECIST_vignette_main: style files
bundfussr Nov 29, 2023
48ee1bb
#233 iRECIST_vignette_main: fix typos
bundfussr Dec 5, 2023
83d4e66
#233 - iRECIST vignette - 3rd round comment update.
vinhn23 Dec 6, 2023
4eddbec
233 - updated sort for AVAL
vinhn23 Dec 8, 2023
070e058
#233 iRECIST_vignette_main: add changelog item
bundfussr Dec 12, 2023
1b6857c
Merge branch 'main' into 233_iRECIST_vignette_main
bundfussr Dec 12, 2023
cd2b86e
#233 iRECIST_vignette_main: clean up Changelog
bundfussr Dec 12, 2023
617e32e
Merge branch 'main' into 233_iRECIST_vignette_main
bundfussr Dec 13, 2023
e31da2b
Merge branch 'main' into 233_iRECIST_vignette_main
bundfussr Dec 13, 2023
2719463
#233 iRECIST_vignette_main: fix links
bundfussr Dec 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions .github/ISSUE_TEMPLATE/05_onboard.yml

This file was deleted.

12 changes: 5 additions & 7 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
Please add "Closes #<issue number>" to the title of the pull request. Then the
issue is closed automatically once it is merged to `main`.
Thank you for your Pull Request! We have developed this task checklist from the [Development Process Guide](https://pharmaverse.github.io/admiraldev/articles/development_process.html) to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Thank you for your Pull Request! We have developed this task checklist from the [Development Process Guide](https://pharmaverse.github.io/admiraldev/main/articles/development_process.html) to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the `devel` branch until you have checked off each task.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the `main` branch until you have checked off each task.

- [ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update). Then the issue is closed automatically once it is merged to `main`.
- [ ] Code is formatted according to the [tidyverse style guide](https://style.tidyverse.org/). Run `styler::style_file()` to style R and Rmd files
- [ ] Updated relevant unit tests or have written new unit tests - See [Unit Test Guide](https://pharmaverse.github.io/admiraldev/main/articles/unit_test_guidance.html#writing-unit-tests-in-admiral)
- [ ] If you removed/replaced any function and/or function parameters, did you fully follow the [deprecation guidance](https://pharmaverse.github.io/admiraldev/main/articles/programming_strategy.html#deprecation)?
- [ ] Updated relevant unit tests or have written new unit tests - See [Unit Test Guide](https://pharmaverse.github.io/admiraldev/articles/unit_test_guidance.html#writing-unit-tests-in-admiral)
- [ ] If you removed/replaced any function and/or function parameters, did you fully follow the [deprecation guidance](https://pharmaverse.github.io/admiraldev/articles/programming_strategy.html#deprecation)?
- [ ] Update to all relevant roxygen headers and examples
- [ ] Run `devtools::document()` so all `.Rd` files in the `man` folder and the `NAMESPACE` file in the project root are updated appropriately
- [ ] Address any updates needed for vignettes and/or templates
Expand Down
2 changes: 2 additions & 0 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ navbar:
href: articles/adtr.html
- text: Creating and Using New Anti-Cancer Start Date
href: articles/nactdt.html
- text: Creating ADRS with iRECIST endpoints
href: articles/irecist.html
bundfussr marked this conversation as resolved.
Show resolved Hide resolved
slack:
icon: fa-slack
href: https://app.slack.com/client/T028PB489D3/C02M8KN8269
Expand Down
6 changes: 6 additions & 0 deletions inst/WORDLIST
Original file line number Diff line number Diff line change
@@ -1,20 +1,25 @@
ACCB
ADRS
ADSL
ADTR
ADTTE
ADaM
ADaMs
BCP
BICR
BOR
Biologics
CBCP
CDISC
CRF
GlaxoSmithKline
Hoffmann
IMWG
IRF
LLC
LSTA
Myeloma
OVRB
PFS
Pre
RECIST
Expand All @@ -31,6 +36,7 @@ evaluable
fil
fmt
funder
iCPD
iRECIST
myeloma
pharmaverse
Expand Down
Loading
Loading