Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating get_terms() file with new terminology #54

Closed
zdz2101 opened this issue Aug 18, 2023 · 0 comments · Fixed by #55
Closed

Updating get_terms() file with new terminology #54

zdz2101 opened this issue Aug 18, 2023 · 0 comments · Fixed by #55
Assignees
@zdz2101

Comments

@zdz2101
Copy link
Collaborator

zdz2101 commented Aug 18, 2023 

          > @manciniedoardo @jeffreyad Looks like there is some relatively "hard-coded" things with related to `admiral_smq_db` / `smq_db` with respective to the `get_terms()` function. Looks like all instances in this [file for `get_terms](https://github.com/pharmaverse/pharmaversesdtm/blob/devel/R/get_terms.R) any mention of "admiral_" needs to be removed to make this work?

@kaz462 would you mind please actioning this in pharmaversesdtm? thanks

Originally posted by @manciniedoardo in pharmaverse/admiral#2057 (comment)
@zdz2101 zdz2101 self-assigned this Aug 18, 2023
zdz2101 pushed a commit that referenced this issue Aug 18, 2023
feat: #54 align terminology in data with get_terms() function
a1bed25
@zdz2101 zdz2101 linked a pull request Aug 18, 2023 that will close this issue
Closes #54 align terminology in data with get_terms() function #55
Merged
14 tasks
kaz462 pushed a commit that referenced this issue Aug 22, 2023
@zdz2101
feat: #54 align terminology in data with get_terms() function (#55)
8061842 
Co-authored-by: Zelos Zhu <zdz2101@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdz2101 zdz2101

Labels
None yet
Projects
admiral (sdtm/adam, dev, ci, template, core)
Status: Archive
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #54 align terminology in data with get_terms() function pharmaverse/pharmaversesdtm
1 participant
@zdz2101