Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #54 align terminology in data with get_terms() function #55

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

zdz2101
Copy link
Collaborator

@zdz2101 zdz2101 commented Aug 18, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@zdz2101 zdz2101 linked an issue Aug 18, 2023 that may be closed by this pull request
@github-actions
Copy link

Code Coverage

Package Line Rate Health
pharmaversesdtm 0%
Summary 0% (0 / 41)

@zdz2101
Copy link
Collaborator Author

zdz2101 commented Aug 18, 2023

Some context: the checks in pharmaverse/admiral#2057 were failing because it was not able to fetch the admiral_smq_db and admiral_sdg_db using the get_terms() function which is to be expected with the removal of "admiral_" in the name under data.R . By swapping out instances of "admiral_" in the get_terms() function, it should resolve the previously mentioned pull request

Copy link
Contributor

@kaz462 kaz462 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zdz2101 Thanks a lot for fixing this issue!

@kaz462 kaz462 merged commit 8061842 into devel Aug 22, 2023
21 checks passed
@kaz462 kaz462 deleted the 54_update_get_terms_terminology@devel branch August 22, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating get_terms() file with new terminology
2 participants