Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look if the implementation of the binary sorting of nodes works as expected and add tests #9

Open
jordanmontt opened this issue Dec 3, 2021 · 0 comments

Comments

@jordanmontt
Copy link
Member

jordanmontt commented Dec 3, 2021

Currently the nodes are stores in a collection. We have two types of nodes: the "model nodes" that are the ones that the user send as a parameters; and the graph nodes which are nodes that we use internally as a data structure. We store those nodes in a collection. When we want to search in which graph node is a given user node we need to do a linear search. There is support for doing a binary search.

This issue is to make sure that the binary search is done right and it works on all cases and to add tests.

@jordanmontt jordanmontt changed the title Look at the binary sorting of nodes if it is causing problems Look if the implementation of the binary sorting of nodes works as expected and add tests Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant