Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Merge BlGridLayoutImpl into BlGridLayout #573

Open
tinchodias opened this issue Aug 5, 2024 · 5 comments
Open

Cleanup: Merge BlGridLayoutImpl into BlGridLayout #573

tinchodias opened this issue Aug 5, 2024 · 5 comments

Comments

@tinchodias
Copy link
Collaborator

BlGridLayoutImpl is only referenced from BlGridLayout's initialize, and then it's used by forwarding BlGridLayout's API to BlGridLayoutImpl.

This may be a reminiscence of a port from another library, as the Impl suffix is not common in Pharo.

@tinchodias
Copy link
Collaborator Author

Out of curiosity, I looked for the history.
When you check for history of BlGridLayout methods in Calypso, you jump until the migration from Filetree to Tonel. I checked in an external tool for history before that commit, and the layouts were already in the beginning of this repo: 49d20c1 (~2016).

The original sources should be smalltalkhub. I looked in their archives and there are 2 candidates:

Maybe @plantec knows

@tinchodias
Copy link
Collaborator Author

Same happens between BlFlowLayoutMeasurer and BlFlowLayout.

@plantec
Copy link
Collaborator

plantec commented Aug 5, 2024

ahh, ok. I think Glenn did it.
A port from a java API I guess

@tinchodias
Copy link
Collaborator Author

This comment in linear layout lead me to Android (https://developer.android.com/reference/android/view/View.MeasureSpec)

"The lengthMode is either UNSPECIFIED or AT_MOST, and
this child is only laid out using excess space.
Measure using FIT_CONTENT so that we can find out the view's optimal length.
We'll restore the original length of 0 after measurement."

@tinchodias
Copy link
Collaborator Author

Additional info (weird): Both BlGridLayoutImpl and BlGridLayout are subclasses of BlLayout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants